Closed Bug 649810 Opened 9 years ago Closed 9 years ago

SeaMonkey 2.1pre Windows installer ignores extension choices (installs always all extensions)

Categories

(SeaMonkey :: Installer, defect, major)

x86
Windows 7
defect
Not set
major

Tracking

(firefox5 fixed, blocking-seamonkey2.1 final+)

VERIFIED FIXED
seamonkey2.1final
Tracking Status
firefox5 --- fixed
blocking-seamonkey2.1 --- final+

People

(Reporter: adriank, Assigned: mcsmurf)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

When choosing custom install in the SeaMonkey 2.1pre Windows installer and deselecting some of the extensions (my test configuration: deselecting all, but ChatZilla), all the extensions, no matter if selected or not, get installed. Probably a result of the recent move to install them as "user-installed" extenions...?

The test was done on a freshly installed Win7 without a previous Sm installation or profile on it.
Blocks: 627240
Keywords: regression
Severity: normal → major
blocking-seamonkey2.1: --- → ?
Also reported by several 2.1b3 users in the MozillaZine forums, http://forums.mozillazine.org/viewtopic.php?f=6&t=2167811
This is probably due to the changes of moving the extensions to be installed into the profile. Still, I thought I made things work just as before.

mcsmurf, any possibility you could take a look what's going on there?
blocking-seamonkey2.1: ? → final+
This one is similar to Bug 590575, need to change that path in the packager file.
Attached patch WIP (obsolete) — Splinter Review
Patch does not work yet.
Assignee: installer → bugzilla
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Tested and works fine.
Attachment #528078 - Attachment is obsolete: true
Attachment #528085 - Flags: feedback?(bugspam.Callek)
Comment on attachment 528085 [details] [diff] [review]
Patch

We'll need this on m-2.0, m-c, and m-aurora. I hope I can convince drivers to accept since, SeaMonkey is the only app to use this, and it directly affects our end-user experience.
Attachment #528085 - Flags: review?(khuey)
Attachment #528085 - Flags: feedback?(bugspam.Callek)
Attachment #528085 - Flags: feedback+
I think we missed the train for the mozilla-aurora merge.
(In reply to comment #7)
> I think we missed the train for the mozilla-aurora merge.

For the merge, yes, for a very-low-risk high-value late-checkin, maybe not.
Comment on attachment 528085 [details] [diff] [review]
Patch

I'll take Kyle or Mitch for this. (Kyle's away, and this bug is a SeaMonkey blocker, so greater speed is appreciated)
Attachment #528085 - Flags: review?(mitchell.field)
Comment on attachment 528085 [details] [diff] [review]
Patch

If it's tested not to break Firefox, r=me.

(/me can't wait until catlee makes this all python).
Attachment #528085 - Flags: review?(khuey) → review+
Attachment #528085 - Flags: review?(mitchell.field) → review+
Comment on attachment 528085 [details] [diff] [review]
Patch

This is a patch that only affects SeaMonkey, it fixes a quite severe bug in the installer. This code has been ifdef'd with "MOZ_OPTIONAL_PKG_LIST", only the SeaMonkey installer uses this feature in the build system.
Attachment #528085 - Flags: review-
Attachment #528085 - Flags: review+
Attachment #528085 - Flags: approval-mozilla-aurora?
Attachment #528085 - Flags: review- → review+
Comment on attachment 528085 [details] [diff] [review]
Patch

This is a patch that only affects SeaMonkey, it fixes a quite severe bug in the
installer. This code has been ifdef'd with "MOZ_OPTIONAL_PKG_LIST", only the
SeaMonkey installer uses this feature in the build system.
Attachment #528085 - Flags: approval2.0?
Comment on attachment 528085 [details] [diff] [review]
Patch

Approved for aurora on the understanding that it is effectively NPOTB
Attachment #528085 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #528085 - Flags: approval2.0? → approval2.0+
I think Called checked this patch in to mozilla-2.0 :) http://hg.mozilla.org/releases/mozilla-2.0/rev/f43e15acc6ca and the relbranch: http://hg.mozilla.org/releases/mozilla-2.0/rev/ac9cf29de0d2
(In reply to comment #15)
> I think Called checked this patch in to mozilla-2.0 :)
> http://hg.mozilla.org/releases/mozilla-2.0/rev/f43e15acc6ca and the relbranch:
> http://hg.mozilla.org/releases/mozilla-2.0/rev/ac9cf29de0d2

I did, but was waiting for all these tests to appear on mozilla's tbpl :-)

also did: http://hg.mozilla.org/mozilla-central/rev/8ff1e817d45e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1final
I was told to mark this bug like that :)
Whiteboard: status-firefox5:fixed
Whiteboard: status-firefox5:fixed
looks fixed. setting flag. please re-set that flag if I'm wrong.
Verified fixed for SeaMonkey 2.1 in RC1, Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.