649810 - SeaMonkey 2.1pre Windows installer ignores extension choices (installs always all extensions)

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Adrian Kalla [:adriank]]

When choosing custom install in the SeaMonkey 2.1pre Windows installer and deselecting some of the extensions (my test configuration: deselecting all, but ChatZilla), all the extensions, no matter if selected or not, get installed. Probably a result of the recent move to install them as "user-installed" extenions...?

The test was done on a freshly installed Win7 without a previous Sm installation or profile on it.

Comment 1

[rsx11m]

Also reported by several 2.1b3 users in the MozillaZine forums, http://forums.mozillazine.org/viewtopic.php?f=6&t=2167811

Comment 2

[Robert Kaiser]

This is probably due to the changes of moving the extensions to be installed into the profile. Still, I thought I made things work just as before.

mcsmurf, any possibility you could take a look what's going on there?

Comment 3

[Frank Wein [:mcsmurf]]

This one is similar to Bug 590575, need to change that path in the packager file.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: WIP

Patch does not work yet.

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch

Tested and works fine.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 528085 [details] [diff] [review]
Patch

We'll need this on m-2.0, m-c, and m-aurora. I hope I can convince drivers to accept since, SeaMonkey is the only app to use this, and it directly affects our end-user experience.

Comment 7

[Philip Chee]

I think we missed the train for the mozilla-aurora merge.

Comment 8

[Robert Kaiser]

(In reply to comment #7)
> I think we missed the train for the mozilla-aurora merge.

For the merge, yes, for a very-low-risk high-value late-checkin, maybe not.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 528085 [details] [diff] [review]
Patch

I'll take Kyle or Mitch for this. (Kyle's away, and this bug is a SeaMonkey blocker, so greater speed is appreciated)

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 528085 [details] [diff] [review]
Patch

If it's tested not to break Firefox, r=me.

(/me can't wait until catlee makes this all python).

Comment 11

[Frank Wein [:mcsmurf]]

Comment on attachment 528085 [details] [diff] [review]
Patch

This is a patch that only affects SeaMonkey, it fixes a quite severe bug in the installer. This code has been ifdef'd with "MOZ_OPTIONAL_PKG_LIST", only the SeaMonkey installer uses this feature in the build system.

Comment 12

[Frank Wein [:mcsmurf]]

Comment on attachment 528085 [details] [diff] [review]
Patch

This is a patch that only affects SeaMonkey, it fixes a quite severe bug in the
installer. This code has been ifdef'd with "MOZ_OPTIONAL_PKG_LIST", only the
SeaMonkey installer uses this feature in the build system.

Comment 13

[Johnathan Nightingale [:johnath]]

Comment on attachment 528085 [details] [diff] [review]
Patch

Approved for aurora on the understanding that it is effectively NPOTB

Comment 14

[Frank Wein [:mcsmurf]]

Comment on attachment 528085 [details] [diff] [review]
Patch

Pushed to mozilla-aurora: http://hg.mozilla.org/mozilla-aurora/rev/e75f8f383215

Comment 15

[Frank Wein [:mcsmurf]]

I think Called checked this patch in to mozilla-2.0 :) http://hg.mozilla.org/releases/mozilla-2.0/rev/f43e15acc6ca and the relbranch: http://hg.mozilla.org/releases/mozilla-2.0/rev/ac9cf29de0d2

Comment 16

[Justin Wood (:Callek)]

(In reply to comment #15)
> I think Called checked this patch in to mozilla-2.0 :)
> http://hg.mozilla.org/releases/mozilla-2.0/rev/f43e15acc6ca and the relbranch:
> http://hg.mozilla.org/releases/mozilla-2.0/rev/ac9cf29de0d2

I did, but was waiting for all these tests to appear on mozilla's tbpl :-)

also did: http://hg.mozilla.org/mozilla-central/rev/8ff1e817d45e

Comment 17

[Frank Wein [:mcsmurf]]

I was told to mark this bug like that :)

Comment 18

[Asa Dotzler [:asa]]

looks fixed. setting flag. please re-set that flag if I'm wrong.

Comment 19

[rsx11m]

Verified fixed for SeaMonkey 2.1 in RC1, Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1.