649841 - First-run low-memory warning: raise to 512MB

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Thomas Arend [:tarend]]

Change from currently 256MB to 512 MB -->
Phones with less than 512MB memory should see the warning.

See also Bug 633649

Comment 1

[Geoff Brown [:gbrown]]

Attachment: Change existing check for 256 MB to 512 MB

Comment 2

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/743b3a54b087

Comment 3

[Aaron Train [:aaronmt]]

Was this patch tested on devices with 512MB RAM capacity? 

A user filed report in bug 652787 on the 04/26 nightly is using an LG Optimus 2X [1], and a Nexus S [2]. Both devices have 512MB RAM capacity. This leads to a suprising message on first boot, which would indicate that both those devices are unsupported.

[1] http://pdadb.net/index.php?m=specs&id=2693&c=lg_p990_optimus_2x_lg_star
[2] http://pdadb.net/index.php?m=specs&id=2690&c=samsung_gt-i9020_nexus_s

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I assume the confusion is around "with less than 512MB"

The patch is "less than or equal to 512MB":

>+ return Integer.parseInt(totalMem) <= 524288L;

which I assume should be:

>+ return Integer.parseInt(totalMem) < 524288L;

Comment 5

[Aaron Train [:aaronmt]]

Correct me if I'm wrong, but MemTotal will only list usable not all all physical addressable space? As it seems 512MB of what would be be addressable by the android kernel, or user space is never the case. This check would then be insufficient and false, as phones with 512MB RAM will get this message.

Comment 6

[Tony Chung [:tchung]]

see bug 652787

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's not reopen this bug if we have opened bug 652787. Only one bug is enough.

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Verified Fixed - Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110426 Firefox/6.0a1 Fennec/6.0a1 ID:20110426043230

Comment 9

[Aaron Train [:aaronmt]]

(In reply to comment #8)
> Verified Fixed - Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110426
> Firefox/6.0a1 Fennec/6.0a1 ID:20110426043230

Which phone, and would you be able to cat the output from MemTotal  in /proc/meminfo, and post it for bug 652787?

Comment 10

[Thomas Arend [:tarend]]

See Bug 659412 - Motorola Defy users report that they see the low memory warning.