652787 - Unsupported message displayed on devices with sufficient memory (512MB)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Attachment: message

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110426 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2) and Nexus S (Android 2.3)

Steps to reproduce:
1. Download and install mozilla-central build 
2. Start Fennec

Expected results:
Fennec should start with no problem

Actual results:
A pop-up message appears saying: "Fennec does not support this device and you may experience problems", see screenshot.

Comment 1

[Aaron Train [:aaronmt]]

This is a result of changes in the check for available system resources from 256MB to 512MB  in bug 649841. The problem is that both your devices do have 512MB, which leads me to believe that this check is not sufficient.

This shouldn't appear as both your listed phones the LG Optimus 2X [1] have 512MB ram, alongside the Nexus S [2].

[1] http://pdadb.net/index.php?m=specs&id=2693&c=lg_p990_optimus_2x_lg_star
[2] http://pdadb.net/index.php?m=specs&id=2690&c=samsung_gt-i9020_nexus_s

Comment 2

[Aaron Train [:aaronmt]]

Raised question in other bug, comment #5 https://bugzilla.mozilla.org/show_bug.cgi?id=649841#c5

Comment 3

[Geoff Brown [:gbrown]]

The amount of memory reported by the system does not match the published specs for the device. This is an Android peculiarity noted on forums:

http://forum.xda-developers.com/showthread.php?t=482228
http://groups.google.com/group/android-developers/browse_thread/thread/3d9dc4489d263372

I will see if I can find a better way to check for memory.

Comment 4

[Geoff Brown [:gbrown]]

I could not find a better way to check for memory.

The way we are checking for memory - checking /proc/meminfo's "MemTotal" - is indicative of "the amount of RAM available to the kernel and higher-level
system as regular memory". But this value is usually significantly smaller than the value quoted in manufacturer's specs. For many "512 MB" devices, the system reports MemTotal in the range 300 MB - 400 MB (the actual value differs from device to device). 

The original memory check - http://hg.mozilla.org/mozilla-central/rev/385abb827ff3 - for MemTotal <= 256 MB was actually an effective check for a (approximately) 512 MB device. We should probably revert to that revision. But then why was bug 649841 opened? Is there a particular device slipping past the 256 MB check inappropriately??

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

the amount of memory available is probably the number we want. Some manufacturers report their total memory to include things like gpu memory which the app and the OS could never utilize. 

That being said, 512 is probably the wrong threshold, something in the 300s makes more sense.

to Geoff's question, I believe the xperia x10 was the device we wanted to include in the unsupported side of things.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

What's the plan to get the right number? Can look survey a few 512MB phones and see what gets reported? What gets reported for the xperia x10 ?

Comment 7

[Tony Chung [:tchung]]

nom for blocking.

Comment 8

[Geoff Brown [:gbrown]]

For the xperia x10, these posts report:
http://www.esato.com/archive/t.php/t-196107,1.html              MemTotal:
270604 kB
http://forum.xda-developers.com/archive/index.php/t-683081.html MemTotal:
274608 kB

My Nexus 1 reports  395108 Kb
My Galaxy S reports 374080 Kb


How about 300000 Kb for a threshold? Or do we want a more exhaustive study of
devices?

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

300000kb works

Comment 10

[Geoff Brown [:gbrown]]

Attachment: Change low memory threshold to 300000 kb

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

From my x10
MemTotal: 287000 kB
G2
MemTotal: 380192 kB
Ideos s7
MemTotal: 425096 kB

Comment 12

[Geoff Brown [:gbrown]]

Attachment: Change low memory threshold to 300000 kb (updated check-in comment)

Comment 13

[Aaron Train [:aaronmt]]

My only concern is seeing the false positive messages on compatible phones; hopefully this threshold is adequate.

Comment 14

[Geoff Brown [:gbrown]]

Comment on attachment 528711 [details] [diff] [review]
Change low memory threshold to 300000 kb (updated check-in comment)

r=blassey

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/e02b054e8b45

Comment 16

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110429 Firefox/6.0a1 Fennec /6.0a1 

Device: HTC Desire Z (android 2.2)