Closed Bug 650205 Opened 10 years ago Closed 10 years ago

Implement devicemanager using adb

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch WIP patch (obsolete) — Splinter Review
it still needs work obviously, but with this I can run tests
Depends on: 649825, 649919
Attached patch patch (obsolete) — Splinter Review
this adds an addtional flag to runtestsremote.py --dm_trans which you can be set to either sut or adb and defaults to adb

I've tested this by running the gfx mochitests over adb, but there should be additional testing, especially with the sut transport before this lands
Assignee: nobody → blassey.bugs
Attachment #526187 - Attachment is obsolete: true
Attachment #530755 - Flags: review?(jmaher)
I added this in for the reftest harness as well.  In general I give the patch an r+.  

We should land both patches at the same time, but getting this rolled out will be a bit more difficult.  we need to update the setup/config/cleanup tools that releng uses so they reference the SUT devicemanager instead of the new base class.  We will also need to work this into talos.
Attachment #530755 - Attachment is obsolete: true
Attachment #530755 - Flags: review?(jmaher)
Attachment #531099 - Flags: review?(blassey.bugs)
Attachment #531099 - Flags: review?(blassey.bugs) → review+
r=blassey based on interdiff
http://hg.mozilla.org/mozilla-central/rev/43949eb48546
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.