As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 650205 - Implement devicemanager using adb
: Implement devicemanager using adb
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Brad Lassey [:blassey] (use needinfo?)
: Gregory Szorc [:gps]
Depends on: 649919 649825
  Show dependency treegraph
Reported: 2011-04-14 22:57 PDT by Brad Lassey [:blassey] (use needinfo?)
Modified: 2011-05-12 12:27 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

WIP patch (16.42 KB, patch)
2011-04-14 22:57 PDT, Brad Lassey [:blassey] (use needinfo?)
no flags Details | Diff | Splinter Review
patch (16.81 KB, patch)
2011-05-06 15:22 PDT, Brad Lassey [:blassey] (use needinfo?)
no flags Details | Diff | Splinter Review
devicemanager adb and integrated into harnesses (1.0) (22.84 KB, patch)
2011-05-09 12:07 PDT, Joel Maher ( :jmaher)
blassey.bugs: review+
Details | Diff | Splinter Review

Description User image Brad Lassey [:blassey] (use needinfo?) 2011-04-14 22:57:34 PDT
Created attachment 526187 [details] [diff] [review]
WIP patch

it still needs work obviously, but with this I can run tests
Comment 1 User image Brad Lassey [:blassey] (use needinfo?) 2011-05-06 15:22:31 PDT
Created attachment 530755 [details] [diff] [review]

this adds an addtional flag to --dm_trans which you can be set to either sut or adb and defaults to adb

I've tested this by running the gfx mochitests over adb, but there should be additional testing, especially with the sut transport before this lands
Comment 2 User image Joel Maher ( :jmaher) 2011-05-09 12:07:09 PDT
Created attachment 531099 [details] [diff] [review]
devicemanager adb and integrated into harnesses (1.0)

I added this in for the reftest harness as well.  In general I give the patch an r+.  

We should land both patches at the same time, but getting this rolled out will be a bit more difficult.  we need to update the setup/config/cleanup tools that releng uses so they reference the SUT devicemanager instead of the new base class.  We will also need to work this into talos.
Comment 3 User image Brad Lassey [:blassey] (use needinfo?) 2011-05-09 12:33:45 PDT
r=blassey based on interdiff
Comment 4 User image Joel Maher ( :jmaher) 2011-05-12 12:27:54 PDT

Note You need to log in before you can comment on or make changes to this bug.