Closed
Bug 650244
Opened 10 years ago
Closed 10 years ago
Error in test_tmpl_storage_bad_parameters_*.xul or test_tmpl_storage_badquery.xul or test_tmpl_storage_baddatasource.xul or test_tmpl_invalidqp.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ ..."
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: rcampbell, Assigned: Gavin)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
2.13 KB,
patch
|
ehsan
:
review+
enndeakin
:
feedback-
|
Details | Diff | Splinter Review |
From the log: 822 INFO TEST-PASS | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_bad_parameters_3.xul | storage listbox with bad query parameters NEXT ERROR 823 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_bad_parameters_3.xul | correct number of logged messages - got 2, expected 1 824 INFO TEST-PASS | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_bad_parameters_3.xul | logged message 1 - "Error parsing template: a query parameter cannot be bound to the SQL query" should equal "Error parsing template: a query parameter cannot be bound to the SQL query" 825 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_bad_parameters_3.xul | logged message 2 - got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent", expected undefined 826 INFO TEST-END | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_bad_parameters_3.xul | finished in 768ms 827 INFO TEST-START | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_baddatasource.xul WARNING: NS_ENSURE_TRUE(sf) failed: file ../../../docshell/base/nsDocShell.cpp, line 4970 WARNING: NS_ENSURE_TRUE(sf) failed: file ../../../docshell/base/nsDocShell.cpp, line 4970 WARNING: NS_ENSURE_SUCCESS(rv, 0) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 2917 As seen here: http://tinderbox.mozilla.org/showlog.cgi?log=Devtools/1302788703.1302792305.29464.gz#err0
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
Summary: Error in test_tmpl_storage_bad_parameters_3.xul | correct number of logged messages - got 2, expected 1 → Error in test_tmpl_storage_bad_parameters_3.xul or test_tmpl_storage_bad_parameters_2.xul or test_tmpl_storage_badquery.xul
Updated•10 years ago
|
Component: XUL Widgets → Places
QA Contact: xul.widgets → places
Summary: Error in test_tmpl_storage_bad_parameters_3.xul or test_tmpl_storage_bad_parameters_2.xul or test_tmpl_storage_badquery.xul → Error in test_tmpl_storage_bad_parameters_3.xul or test_tmpl_storage_bad_parameters_2.xul or test_tmpl_storage_badquery.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent"
Comment 5•10 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1305644257.1305648039.16707.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test s: talos-r3-snow-052 912 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_badquery.xul | correct number of logged messages - got 2, expected 1 914 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/content/xul/templates/tests/chrome/test_tmpl_storage_badquery.xul | logged message 2 - got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent", expected undefined PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed) PROCESS-CRASH | Main app process exited normally | application crashed (minidump found) Thread 0 (crashed)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•10 years ago
|
Summary: Error in test_tmpl_storage_bad_parameters_3.xul or test_tmpl_storage_bad_parameters_2.xul or test_tmpl_storage_badquery.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent" → Error in test_tmpl_storage_bad_parameters_*.xul or test_tmpl_storage_badquery.xul or test_tmpl_storage_baddatasource.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent"
Assignee | ||
Comment 7•10 years ago
|
||
These tests are too fragile. Places just happens to be doing it's cleanup while they're running, and they can't tolerate someone else spamming the console. The tests should not assume that they have the console to themselves.
Component: Places → XUL
Product: Toolkit → Core
QA Contact: places → xptoolkit.widgets
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 10•10 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Private-Browsing/1306364245.1306368185.26500.gz Please disable your tests until they get unbroken.
Assignee | ||
Comment 11•10 years ago
|
||
I verified that the tests still fail if the error reporting is disabled (made nsXULContentUtils::LogTemplateError a noop).
Updated•10 years ago
|
Attachment #535408 -
Flags: review? → review+
Comment 12•10 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/d998c37534b1
Whiteboard: [orange] → [orange][fixed-in-cedar]
Target Milestone: --- → mozilla7
Comment 13•10 years ago
|
||
Comment on attachment 535408 [details] [diff] [review] fix the tests Looks wrong to me. This will ignore all extra errors even when those extra errors are template related, no? Is there a bug on removing the places junk being output?
Attachment #535408 -
Flags: feedback-
Assignee | ||
Comment 15•10 years ago
|
||
(In reply to comment #13) > Looks wrong to me. This will ignore all extra errors even when those extra > errors are template related, no? Yes. Is it important to test that no additional template errors were produced? That seems unlikely to happen (and a minor bug if it somehow does). I suppose you could add an else branch that checks is(messages[m].indexOf("Error parsing template"), -1, "additional message should not be a template message") or something (assuming all of these really do go through nsXULContentUtils::LogTemplateError).
Comment 16•10 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/d998c37534b1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-cedar] → [orange]
Comment 17•10 years ago
|
||
Reopening for Neil's comments to be addressed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 18•10 years ago
|
||
I don't think that's needed, but if so it can happen in another bug.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 19•10 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Beta/1313006338.1313010265.31828.gz
Summary: Error in test_tmpl_storage_bad_parameters_*.xul or test_tmpl_storage_badquery.xul or test_tmpl_storage_baddatasource.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ The database is coherent" → Error in test_tmpl_storage_bad_parameters_*.xul or test_tmpl_storage_badquery.xul or test_tmpl_storage_baddatasource.xul or test_tmpl_invalidqp.xul | got "[ Places Maintenance ]\n> Integrity check\n+ The database is sane\n> Coherence check\n+ ..."
Updated•8 years ago
|
Keywords: intermittent-failure
Updated•8 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•