650366 - accessible/tree/test_combobox.xul fails on OSX

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Hubert Figuiere [:hub]]

see bug 650294 (test disabling)

Comment 2

[Athena]

Attachment: combobox-test-mac-bug-650366.patch

The test fails because the selected menuitem has an extra '✓' child on a mac -- see http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/menu.css#168

So enabling the test with added info for OSX.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Review of attachment 8527123 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks!

Comment 4

[Athena]

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Thanks, already in the uploaded patch.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8527123 [details] [diff] [review]
combobox-test-mac-bug-650366.patch

Review of attachment 8527123 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Athena, if you have tested the new test locally (on Mac of course) and it passes, please go ahead about put the "checkin-needed" keyword to the bug report itself (not the patch). If you don't have permission to do that ping me :)

Comment 6

[Athena]

Thanks for the pointers! Confirmed passing on a mac.

Comment 7

[Carsten Book [:Tomcat]]

David, do we need a try run for this change ?

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Carsten Book [:Tomcat] from comment #7)
> David, do we need a try run for this change ?

Good point - we should! (https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree)

Athena I forgot to ask, can you do a tryserver (https://wiki.mozilla.org/Build:TryServerAsBranch#How_to_push_to_try) run? (If you did already you can just say so here and put the checkin-needed keyword back).

Comment 9

[Athena]

Try run here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=004f4412fb55

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69c0c04139a2

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/69c0c04139a2