650554 - renaming a folder used in a saved search removes the folder from the saved search

Status: RESOLVED DUPLICATE of bug 705080

(Thunderbird :: Search, defect)

Description

[Włodzimierz O. Kubera]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.204 Safari/534.16
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; pl; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9

Virtual search folder is a very good thing.
We can found all e-mails from any person, etc.
After changing it, it is no longer valid.

Reproducible: Always

Steps to Reproduce:
1. Create a virtual search folder (example; where "FROM" consist of "microsoft.com", sth not empty)
2. Save it as a permanent search result (fill in a name, etc).
3. Using Drag & Drop, move all the e-mails from it to the other place
Actual Results:  
Migrating e-mails by drag & drop invalidates the virtual search folder.
After that it will be permanently empty.

Expected Results:  
Such folder should be refreshed automatically after migration or should be in the dialog a button for recall the search.

This is a very good feature, but in a dymically used mailbox the user is forced to reproduce this search folder manually.
It is too hard, because of too many operations.

Comment 1

[Ludovic Hirlimann [:Usul]]

This is probably doable if we use gloda for virtual folder AFAIK we actually don't.

Comment 2

[Wayne Mery (:wsmwk)]

I can't reproduce.
Is this iterating over imap or local folders?
Does it also not update if you click on the folder?
Anything in error console after moving all the messages, or later after moving messages to a folder clicking the virtual?

Comment 3

[Włodzimierz O. Kubera]

I appologize for my bad English, but let me try to answer:
After the creation of the virtual search folder,
it consist of a few e-mails.
I am sorry I can not repoproduce it too.
But I have a folder 'Sony' wich had e-mails from sony.com, etc.
and now is empty, but I have moved them to the other folder,
not deleted them. Virtual folder is epmty after the movemment.
I can not see the change. I think that it should be refreshed.
I do not rememember the exact way for reproduce.
(I could not predict the bug existance)
I have tried another test, Sirs.
I have created an identical folder with a new name, 'Sony2'.
'Sony' is empty and 'Sony2' is not empty.
There is no difference between them in a definition level.
These search folders are off-line, and are not using IMAP on-line checkbox.

P. S.
I can not reproduce the way, but the result is permanent.
I can not help more, I do not remember more.
If I can write a new information, I contact you, Sirs, of course.
Console says nothing about this folder.

These virtual search folders are a great idea :) !

Comment 4

[Włodzimierz O. Kubera]

Please rename the IMAP folder wich consist of all searched e-mails.
These e-mails are no longer available in the virtual search folder.

I have serch folder Sony2 wich was finding e-mail in the Sony IMAP folder.
I have renamed this IMAP folder, and the search folder 'died' :).

P. S.
All e-mails was from that place. Check it with one IMAP folder, plaese.

Comment 5

[David :Bienvenu]

(In reply to comment #1)
> This is probably doable if we use gloda for virtual folder AFAIK we actually
> don't.

Ludo, saved searches don't need gloda for this - they listen for db change events and keep the saved search up to date on the fly, in the UI.

It's quite possible that if you rename a folder, saved searches don't get updated to search the new folders - I don't know if there's an existing bug on that. We could implement this in the same place that we implement the updating of message filters when folders are renamed, or we could make the account manager listen for folder rename events and update any saved searches there. The latter is a bit tricky because we've already generated a folder deleted event, and the original folder would already have been removed from the saved search.

Comment 6

[Wayne Mery (:wsmwk)]

Włodzimierz, is your step 3 of comment 0 that you moved one of the folders that the virtual was searching on? I am indeed having a hard time understanding and your 3 comments don't seem to agree with each other. It may be better if you communicate only using list numbered steps 

see https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc=rename%20saved&short_desc_type=allwordssubstr&type0-0-0=nowords&value0-0-0=count%20counts&resolution=---&product=MailNews%20Core&product=Thunderbird

Comment 7

[Włodzimierz O. Kubera]

It looks like a submitted algorithm is working OK, my fault, I am sorry,
but this error exists in a different way.
These three points are not important now.

The most important information that is true:
It is possbile to have two named virtual search folders with identical
filter definitions, and one would be empty and the second would have e-mails
(E-mails would disapear after a change on theirs locations).

I have read this buglist, my post is about other topic and has been found in the newest Thunderbird.

P. S.
I have posted a method for invalidating a virtual search folder.
I have the Polish version of the mailer, I hope that my translation
is clear enough.

As a customer I want to have the folders up to date after my chanages
or a button for refreshing them.
Your heuristics rarely does not refresh the folder.
A better way would refreshing them too often, in my opinion,
but I am not the author of this excellent program.

Please read my post about renaming an IMAP folder ( comment_4 ).
It has been tested, and that would be an error here
and maybe the core reason of the reported problem.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to comment #7)
> It looks like a submitted algorithm is working OK, my fault, I am sorry,
> but this error exists in a different way.
> These three points are not important now.

so comment 0 is wrong, and that part is working correctly for you?

 
> The most important information that is true:
> It is possbile to have two named virtual search folders with identical
> filter definitions, and one would be empty and the second would have e-mails
> (E-mails would disapear after a change on theirs locations).
> 
> I have read this buglist, my post is about other topic and has been found in
> the newest Thunderbird.
so your problem is not listed in the query of comment 6. and is also not found in https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=substring&short_desc=unified&field0-0-0=short_desc&bug_severity=major&bug_severity=normal&type0-0-1=substring&field0-0-1=keywords&type1-0-1=allwordssubstr&resolution=---&classification=Client%20Software&classification=Components&query_format=advanced&short_desc_type=allwordssubstr&type0-0-0=anywordssubstr&field1-0-0=short_desc&product=MailNews%20Core&product=Thunderbird&field1-0-1=short_desc ??


> P. S.
> I have posted a method for invalidating a virtual search folder.
> I have the Polish version of the mailer, I hope that my translation
> is clear enough.
> 
> As a customer I want to have the folders up to date after my chanages
> or a button for refreshing them.
of course :0

> Your heuristics rarely does not refresh the folder.
> A better way would refreshing them too often, in my opinion,
> but I am not the author of this excellent program.

 
> Please read my post about renaming an IMAP folder ( comment_4 ).
> It has been tested, and that would be an error here
> and maybe the core reason of the reported problem.

please list how you recreate this problem as numbered steps
1.
2.
3.
4,
...
and use as few words as possible.
also state briefly what settings you are using in the virtual folder definition,

Comment 9

[Włodzimierz O. Kubera]

1. Create a virtual search folder (example; where "FROM" consist of
"microsoft.com", sth not empty)
2. Save it as a permanent search result (fill in a name, etc).
3. Rename a source IMAP folder where these e-mails are stored.
(i have tested usage of a single e-mails folder, because I group my corresponce
and all e-mails in a virtual search folder were from the same IMAP place)
As a result of altering its name, e-mails disappeared from the virtual search folder. This is a permanent state of the folder.
They will be availaible in the renamed IMAP folder.
They should visible in both places?

The folder has a filter that will select e-mails, it can not be empty. Checkbox for on-line MIME folders is not checked.

TODO:
Create an IMAP folder 'abc'
Move there all e-mails from 'abc.com'
Create a filter with clause: 'FROM:' consist of 'abc.com'
Save the filter as 'abc'.
Rename IMAP 'abc' to 'abc2'.
After that, the virtual search folder 'abc' is empty and dead,
bacause renameming 'abc2' back to 'abc' does not work too.

( I am using other clause, 'FROM:', but 'FROM, TO, CC, BCC:',
maybe it does not matter ).

P. S.
These virtual folders are in an incorrect place
after creation and are moved to its place
after reopenning the app.
They are sorted by name, not by semantics.
Maybe this is not important...

Comment 10

[David :Bienvenu]

OK, thx, so this could be expressed as:

Renaming a folder used in a saved search removes that folder from the saved search. I'll adjust the title of the bug.