Closed
Bug 650582
Opened 14 years ago
Closed 14 years ago
browser_preferences_text uses a tool-panel-close which is not used on Android
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
|
1.79 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
browser_preferences_text uses a button to close the preferences panel, but the button is not used on Android. Therefore, the tests fail.
Patch uses the undelying BrowserUI method to hide the panel
Attachment #526553 -
Flags: review?(mbrubeck)
|
Assignee | |
Updated•14 years ago
|
Attachment #526553 -
Flags: review?(mbrubeck) → review?(21)
Attachment #526553 -
Flags: review?(21) → review+
|
|
Assignee | |
Comment 1•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 2•14 years ago
|
||
Can you provide STR or a way to verify this please?
|
||
Comment 3•14 years ago
|
||
Probably the same way as bug 650684, comment 4. In this case, the test was only failing on Android, so you should look if this automated test would still be failing on Android.
(That also means that verifying automated tests isn't probably the most useful thing to do, because automated tests more or less verify themselves)
|
|
||
Comment 4•14 years ago
|
||
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110508 Firefox/6.0a1 Fennec/6.0a1
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•