Tests from bug 583514 contain a lot of issues: - Reftests 583514-1.html and 583514-2.html are wrong because they do not use class="reftest-wait" creating an intermittent failure; - The mochitest isn't added to Makefile.in so it's never run; - The mochitest is using netscape.security.PrivilegeManager.enablePrivilege which has been explicitly forbidden some time ago; - The mochitest is using events but do not use event handlers (a trap for random oranges); - It is adding a reftest with a bug number that doesn't correspond to the test bug (bug 409604); - Two reftests are doing exactly the same thing: 409604-1.html and 583514-2.html but one of them don't use reftest-wait; - All reftests would be much more easier to write with mochitests...
Created attachment 526582 [details] [diff] [review] Cleaning All reftests have been removed in favor of a single mochitest. The original mochitest has been removed because content/html/content/test/test_bug409604.html seems to cover what was tested in it.
(In reply to comment #0) > Tests from bug 583514 contain a lot of issues: > - Reftests 583514-1.html and 583514-2.html are wrong because they do not use > class="reftest-wait" creating an intermittent failure; > - The mochitest isn't added to Makefile.in so it's never run; > - The mochitest is using netscape.security.PrivilegeManager.enablePrivilege > which has been explicitly forbidden some time ago; > - The mochitest is using events but do not use event handlers (a trap for > random oranges); > - It is adding a reftest with a bug number that doesn't correspond to the test > bug (bug 409604); > - Two reftests are doing exactly the same thing: 409604-1.html and > 583514-2.html but one of them don't use reftest-wait; > - All reftests would be much more easier to write with mochitests... Thanks for catching this. All of these issues should have ideally been caught at review time. :(
Pushed: http://hg.mozilla.org/mozilla-central/rev/189388b079a8
or
