Note: There are a few cases of duplicates in user autocompletion which are being worked on.

evaluating a null object in the web console returns TypeError: aObject is null

VERIFIED FIXED in Firefox 6

Status

()

Firefox
Developer Tools
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 6
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-devtools][console-1][merged-to-mozilla-central])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
STR:
1. Open a Web Console (cmd/ctrl+shift+k)
2. type "null" in the command line and hit enter

Expected results:
Console should return "null" in the output error.

Actual results:
We get an error, TypeError: aObject is null.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110415 Firefox/6.0a1 aka nightly.

works in Fx4.

Updated

6 years ago
Flags: in-testsuite?
(Assignee)

Comment 1

6 years ago
Created attachment 527077 [details] [diff] [review]
[checked-in][in-devtools] null

simple null check in isIteratorOrGenerator. And a unittest!
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #527077 - Flags: review?(ddahl)
(Assignee)

Comment 2

6 years ago
Comment on attachment 527077 [details] [diff] [review]
[checked-in][in-devtools] null

This fix should block merging to mozilla-central. Fixes a problem with patch in bug 632347.

Updated

6 years ago
Attachment #527077 - Flags: review?(ddahl) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 527077 [details] [diff] [review]
[checked-in][in-devtools] null

adding mossop for some additional review sauce.
Attachment #527077 - Flags: review?(dtownsend)
Attachment #527077 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [checkin][console-1]
(Assignee)

Comment 4

6 years ago
Comment on attachment 527077 [details] [diff] [review]
[checked-in][in-devtools] null

http://hg.mozilla.org/projects/devtools/rev/947401ba2457
Attachment #527077 - Attachment description: null → [in-devtools] null
(Assignee)

Updated

6 years ago
Whiteboard: [checkin][console-1] → [fixed-in-devtools][console-1]
(Assignee)

Comment 5

6 years ago
Comment on attachment 527077 [details] [diff] [review]
[checked-in][in-devtools] null

http://hg.mozilla.org/mozilla-central/rev/947401ba2457
Attachment #527077 - Attachment description: [in-devtools] null → [checked-in][in-devtools] null
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-devtools][console-1] → [fixed-in-devtools][console-1][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6

Comment 6

6 years ago
Verified Fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0a1) Gecko/20110511 Firefox/6.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.