650871 - nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this warning in up-to-date mozilla-central:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp: In member function ‘void nsHttpConnectionMgr::OnMsgReclaimConnection(PRInt32, void*)’:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

The flagged code is:
> 1063             PRInt32 idx;
> 1064             for (idx = 0; idx < ent->mIdleConns.Length(); idx++) {
> 1065                 nsHttpConnection *idleConn = ent->mIdleConns[idx];

Looks like idx just wants to be a PRUint32.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Note: The last usage of |idx| is line 1071 (the last line in the patch's context):
http://mxr.mozilla.org/mozilla-central/search?string=idx&find=nsHttpConnectionMgr.cpp&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: hg changeset for checkin

Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650987 as ridealongs)

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/f348404cd074