Closed Bug 650871 Opened 9 years ago Closed 9 years ago

nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [build_warning])

Attachments

(2 files)

Filing bug on this warning in up-to-date mozilla-central:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp: In member function ‘void nsHttpConnectionMgr::OnMsgReclaimConnection(PRInt32, void*)’:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

The flagged code is:
> 1063             PRInt32 idx;
> 1064             for (idx = 0; idx < ent->mIdleConns.Length(); idx++) {
> 1065                 nsHttpConnection *idleConn = ent->mIdleConns[idx];

Looks like idx just wants to be a PRUint32.
Attachment #526769 - Flags: review+
Attachment #526769 - Flags: review?(jduell.mcbugs) → review+
Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650987 as ridealongs)
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/f348404cd074
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.