nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

RESOLVED FIXED in mozilla6

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Filing bug on this warning in up-to-date mozilla-central:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp: In member function ‘void nsHttpConnectionMgr::OnMsgReclaimConnection(PRInt32, void*)’:
> netwerk/protocol/http/nsHttpConnectionMgr.cpp:1064:56: warning: comparison between signed and unsigned integer expressions

The flagged code is:
> 1063             PRInt32 idx;
> 1064             for (idx = 0; idx < ent->mIdleConns.Length(); idx++) {
> 1065                 nsHttpConnection *idleConn = ent->mIdleConns[idx];

Looks like idx just wants to be a PRUint32.
(Assignee)

Comment 1

6 years ago
Created attachment 526769 [details] [diff] [review]
fix
Attachment #526769 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #526769 - Flags: review? → review?(jduell.mcbugs)
(Assignee)

Comment 2

6 years ago
Note: The last usage of |idx| is line 1071 (the last line in the patch's context):
http://mxr.mozilla.org/mozilla-central/search?string=idx&find=nsHttpConnectionMgr.cpp&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Attachment #526769 - Flags: review+
(Assignee)

Updated

6 years ago
Assignee: nobody → dholbert
Attachment #526769 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 527060 [details] [diff] [review]
hg changeset for checkin

Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650987 as ridealongs)
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/f348404cd074
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.