Created attachment 526875 [details] [diff] [review]
Filing bug on these build warnings:
> uriloader/prefetch/OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used
> uriloader/prefetch/OfflineCacheUpdateChild.cpp:65: warning: 'gOfflineCacheUpdateService' defined but not used
I think this is a copy-paste error, from grabbing code from nsOfflineCacheUpdate.cpp including this unused variable, and then the copies-of-the-unused-variable remained even after nsOfflineCacheUpdate.cpp was fixed (in bug 615425).
Attached patch fixes this.
--> adding clobber build log including these warnings to URL field.
The patch also adds the formerly-missing newline at the end of these files. (Bugzilla's patch viewer doesn't show that correctly, but the raw text of the patch does.)
Created attachment 527059 [details] [diff] [review]
hg changeset for checkin
Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650871 as ridealongs)