OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used

RESOLVED FIXED in mozilla6

Status

()

Core
Networking: Cache
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla6
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning], URL)

Attachments

(2 attachments)

Created attachment 526875 [details] [diff] [review]
fix

Filing bug on these build warnings:
> uriloader/prefetch/OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used
> uriloader/prefetch/OfflineCacheUpdateChild.cpp:65: warning: 'gOfflineCacheUpdateService' defined but not used

I think this is a copy-paste error, from grabbing code from nsOfflineCacheUpdate.cpp including this unused variable, and then the copies-of-the-unused-variable remained even after nsOfflineCacheUpdate.cpp was fixed (in bug 615425).

Attached patch fixes this.
Attachment #526875 - Flags: review?(honzab.moz)
 --> adding clobber build log including these warnings to URL field.
The patch also adds the formerly-missing newline at the end of these files.  (Bugzilla's patch viewer doesn't show that correctly, but the raw text of the patch does.)
Assignee: nobody → dholbert
Attachment #526875 - Flags: review?(honzab.moz) → review+
Created attachment 527059 [details] [diff] [review]
hg changeset for checkin

Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650871 as ridealongs)
Keywords: checkin-needed
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/ce7bef9447be
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.