650987 - OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: fix

Filing bug on these build warnings:
> uriloader/prefetch/OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used
> uriloader/prefetch/OfflineCacheUpdateChild.cpp:65: warning: 'gOfflineCacheUpdateService' defined but not used

I think this is a copy-paste error, from grabbing code from nsOfflineCacheUpdate.cpp including this unused variable, and then the copies-of-the-unused-variable remained even after nsOfflineCacheUpdate.cpp was fixed (in bug 615425).

Attached patch fixes this.

Comment 1

[Daniel Holbert [:dholbert]]

 --> adding clobber build log including these warnings to URL field.

Comment 2

[Daniel Holbert [:dholbert]]

The patch also adds the formerly-missing newline at the end of these files.  (Bugzilla's patch viewer doesn't show that correctly, but the raw text of the patch does.)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: hg changeset for checkin

Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650871 as ridealongs)

Comment 4

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ce7bef9447be