Closed
Bug 650987
Opened 14 years ago
Closed 14 years ago
OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used
Categories
(Core :: Networking: Cache, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
(Whiteboard: [build_warning])
Attachments
(2 files)
|
2.21 KB,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
|
2.35 KB,
patch
|
Details | Diff | Splinter Review |
Filing bug on these build warnings:
> uriloader/prefetch/OfflineCacheUpdateParent.cpp:43: warning: 'gOfflineCacheUpdateService' defined but not used
> uriloader/prefetch/OfflineCacheUpdateChild.cpp:65: warning: 'gOfflineCacheUpdateService' defined but not used
I think this is a copy-paste error, from grabbing code from nsOfflineCacheUpdate.cpp including this unused variable, and then the copies-of-the-unused-variable remained even after nsOfflineCacheUpdate.cpp was fixed (in bug 615425).
Attached patch fixes this.
Attachment #526875 -
Flags: review?(honzab.moz)
|
Assignee | |
Comment 1•14 years ago
|
||
--> adding clobber build log including these warnings to URL field.
|
|
Assignee | |
Comment 2•14 years ago
|
||
The patch also adds the formerly-missing newline at the end of these files. (Bugzilla's patch viewer doesn't show that correctly, but the raw text of the patch does.)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dholbert
|
||
Updated•14 years ago
|
Attachment #526875 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Here's the changeset for checkin. (I can't treewatch at the moment; hoping some kind soul can land this & bug 650871 as ridealongs)
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in cedar]
|
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in cedar] → [build_warning]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•