Closed
Bug 651114
Opened 13 years ago
Closed 13 years ago
Clean up browser_tabview_bug612470.js
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 6
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file, 1 obsolete file)
3.97 KB,
patch
|
Details | Diff | Splinter Review |
The test times out in single mode and we could use some of the new head.js functions.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #526971 -
Flags: feedback?(raymond)
Updated•13 years ago
|
Attachment #526971 -
Flags: feedback?(raymond) → feedback+
Assignee | ||
Updated•13 years ago
|
Attachment #526971 -
Flags: review?(ian)
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 526971 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=08df77ceca79
Comment 3•13 years ago
|
||
Comment on attachment 526971 [details] [diff] [review] patch v1 > /* Any copyright is dedicated to the Public Domain. > http://creativecommons.org/publicdomain/zero/1.0/ */ > > // Tests that groups behave properly when closing all tabs but app tabs. I really like that there's a comment at the top here describing what the test is for... might be a good habit to get into. >+ newWindowWithTabView(function (tvwin) { >+ registerCleanupFunction(function () tvwin.close()); > >- addEventListener("tabviewshown", createGroup, false); >- TabView.toggle(); >+ win = tvwin; >+ cw = win.TabView.getContentWindow(); >+ executeSoon(function () onShow()); >+ }, onLoad); I found it a little confusing that of the two functions passed into newWindowWithTabView, one was defined right here and the other was defined above and passed only by name. I think passing them both by name would be clearer (otherwise it's easier to forget which function is for what), though I suppose a middle ground would be to name the functions inline: newWindowWithTabView(function onShow (tvwin) { ... }, function onLoad () { ... }); Anyway, food for thought.
Attachment #526971 -
Flags: review?(ian) → review+
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to comment #3) > I really like that there's a comment at the top here describing what the test > is for... might be a good habit to get into. True. Noted :) > I found it a little confusing that of the two functions passed into > newWindowWithTabView, one was defined right here and the other was defined > above and passed only by name. I think passing them both by name would be > clearer (otherwise it's easier to forget which function is for what) Fixed.
Attachment #526971 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/7b7a77e74c78
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•