Closed
Bug 651477
Opened 13 years ago
Closed 13 years ago
Update setTreatsFilePackagesAsDirectories when user change the filter
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.84 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 646854 doesn't do that. Actually, I wonder if the original code is buggy. To me, the comment and the code are exactly opposite. Am I wrong? In case of, I kept the original behavior. Josh, let me know if I should change that.
Attachment #527246 -
Flags: review?(joshmoz)
Comment on attachment 527246 [details] [diff] [review] Patch v1 Review of attachment 527246 [details] [diff] [review]: I don't think this patch will apply any more.
Attachment #527246 -
Flags: review?(joshmoz)
|
Assignee | |
Comment 2•13 years ago
|
||
Should apply on current trunk.
Attachment #527246 -
Attachment is obsolete: true
Attachment #529971 -
Flags: review?(joshmoz)
Comment on attachment 529971 [details] [diff] [review] Patch v1.1 Review of attachment 529971 [details] [diff] [review]: ----------------------------------------------------------------- I'd leave the behavior alone for now but that comment is wrong. Remove it or fix it and then this patch will be ready to go.
Attachment #529971 -
Flags: review?(joshmoz) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
I've added a FIXME comment pointing to bug 656260. Pushed: http://hg.mozilla.org/mozilla-central/rev/a5f4da293c4e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•