When setting a group item to be active, its "active tab" should be selected

VERIFIED FIXED

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: raymondlee, Assigned: raymondlee)

Tracking

Dependency tree / graph

Details

(Assignee)

Description

6 years ago
See bug 632294 comment 7

"...When you set a group to be active (i.e. UI.setActive(groupItem)), it should select its "active tab". This will likely change the UI's behavior, but for the better...."
Blocks: 653099
bugspam
No longer blocks: 653099
bugspam
Blocks: 660175
(Assignee)

Updated

6 years ago
Assignee: nobody → raymond
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
I've checked the code and it seems it's working as described in comment 0.

When UI.setActive(groupItem) is called, UI._setActiveTab(tabItem) would be called.  

http://hg.mozilla.org/mozilla-central/file/eee0bb5dca28/browser/base/content/tabview/ui.js#l438


There are two exceptions: [1] when an app tab is clicked, the group is set to be active and no active tab item is set. [2] Set the active group and then create a new tab in that group.

[1] http://hg.mozilla.org/mozilla-central/file/eee0bb5dca28/browser/base/content/tabview/groupitems.js#l1145 
[2] http://hg.mozilla.org/mozilla-central/file/eee0bb5dca28/browser/base/content/tabview/groupitems.js#l1785

I think the current implementation covers the requirement in this bug.
Agreed, setting an active group activates the last active tabItem in this group by default. I think that's the behavior we want.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110620 Firefox/7.0a1

Verified on Ubuntu 11.04 x86, WinXP, Win7 x86 and Mac OS X 10.6. Changing from one group to another within panorama activates(focuses) the latest focused tab. 

Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.