Closed
Bug 651867
Opened 14 years ago
Closed 13 years ago
Enable mobile Feedback extension on Nightly channel
Categories
(Firefox for Android Graveyard :: General, enhancement)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aakashd, Assigned: mbrubeck)
Details
Attachments
(1 file, 2 obsolete files)
5.69 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Input is available across the nightly channel too. It'd be great to add it there.
Reporter | ||
Comment 1•14 years ago
|
||
Added feedback to NTT - https://addons.mozilla.org/en-US/mobile/addon/nightly-tester-tools-for-mobil/versions/3.2
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
Also get rid of "About this Beta" which doesn't work on Aurora/Nightly, and anyway is redundant with About Firefox Beta -> Release Notes.
Attachment #551547 -
Attachment is obsolete: true
Attachment #551547 -
Flags: review?(mark.finkle)
Attachment #551552 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #551552 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Missed one line.
Attachment #551552 -
Attachment is obsolete: true
Attachment #551557 -
Flags: review?(mark.finkle)
Comment 5•13 years ago
|
||
Comment on attachment 551557 [details] [diff] [review] patch v3 >diff --git a/mobile/app/profile/extensions/feedback@mobile.mozilla.org/content/overlay.js b/mobile/app/profile/extensions/feedback@mobile.mozilla.org/content/overlay.js > window.addEventListener("UIReadyDelayed", function(aEvent) { > let appInfo = Cc["@mozilla.org/xre/app-info;1"].getService(Ci.nsIXULAppInfo); >- document.getElementById("feedback-about").setAttribute("desc", appInfo.version); > appInfo is unused now, remove it too
Attachment #551557 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c93ffc70dbcc
Whiteboard: [inbound]
Comment 7•13 years ago
|
||
Verified Fixed w/ http://hg.mozilla.org/mozilla-central/rev/08327218cb8b via http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android/1312891959/
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c93ffc70dbcc
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•