Closed Bug 651867 Opened 9 years ago Closed 8 years ago

Enable mobile Feedback extension on Nightly channel

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aakashd, Assigned: mbrubeck)

Details

Attachments

(1 file, 2 obsolete files)

Input is available across the nightly channel too. It'd be great to add it there.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #551547 - Flags: review?(mark.finkle)
Attached patch patch v2 (obsolete) — Splinter Review
Also get rid of "About this Beta" which doesn't work on Aurora/Nightly, and anyway is redundant with About Firefox Beta -> Release Notes.
Attachment #551547 - Attachment is obsolete: true
Attachment #551547 - Flags: review?(mark.finkle)
Attachment #551552 - Flags: review?(mark.finkle)
Attachment #551552 - Flags: review?(mark.finkle) → review+
Attached patch patch v3Splinter Review
Missed one line.
Attachment #551552 - Attachment is obsolete: true
Attachment #551557 - Flags: review?(mark.finkle)
Comment on attachment 551557 [details] [diff] [review]
patch v3

>diff --git a/mobile/app/profile/extensions/feedback@mobile.mozilla.org/content/overlay.js b/mobile/app/profile/extensions/feedback@mobile.mozilla.org/content/overlay.js
>     window.addEventListener("UIReadyDelayed", function(aEvent) {
>       let appInfo = Cc["@mozilla.org/xre/app-info;1"].getService(Ci.nsIXULAppInfo);
>-      document.getElementById("feedback-about").setAttribute("desc", appInfo.version);
> 

appInfo is unused now, remove it too
Attachment #551557 - Flags: review?(mark.finkle) → review+
Blocks: 671454
No longer blocks: 671454
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.