Closed
Bug 671454
Opened 13 years ago
Closed 13 years ago
Implement telemetry ui on mobile
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: taras.mozilla, Assigned: stechz)
References
Details
Attachments
(1 file, 1 obsolete file)
2.25 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•13 years ago
|
||
Madhava, can you provide some guidance on an approach? Desktop has landed a similar feature.
Comment 2•13 years ago
|
||
The following error occurs for 3 times in Error Console: Error: Unable to report telemetry. Source File: jar:file///data/app/org.mozilla.fennec-1.apk!/components/nsPlacesAutoComplete.js Line: 739 I'm able to reproduce it when I browse to http://jeremydouglass.com/gamertextually/images/gt_snowflake_tags-2-ach-large.png Is this error related to this bug? -- Build id : Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110803 Firefox/8.0a1 Fennec/8.0a1 Device: HTC Desire Z OS: Android 2.3.3
Comment 3•13 years ago
|
||
The error mentioned in comment 2 was filed as bug 676246.
Assignee | ||
Comment 4•13 years ago
|
||
Madhava, ping? I'm not sure this needs a lot of UX energy, but maybe a general direction would be helpful to move this bug forward. We can always incrementally improve later. Should we add a call to action on the home page? Do a dialog? Put an option in preferences?
Assignee | ||
Updated•13 years ago
|
Assignee: mark.finkle → ben
Assignee | ||
Comment 5•13 years ago
|
||
Called pref "Send performance data." I would have preferred to add a "to Mozilla," but that overflows text on the pre-Honeycomb theme.
Attachment #551180 -
Flags: review?(mark.finkle)
Comment 6•13 years ago
|
||
Comment on attachment 551180 [details] [diff] [review] Implement telemtry ui on mobile Looks good, but I'd like to see the new pref in a new section. "Privacy & Security" is not exactly the best place for it. Let's add a new <settings> group under "Content" called "Other" (with an id of "prefs-other"). Add the telemetry pref there. New patch and I'll r+ it
Attachment #551180 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 7•13 years ago
|
||
An other section? Bleck. What's wrong with Privacy & Security? This fits best as a privacy option.
Comment 8•13 years ago
|
||
(In reply to Benjamin Stover (:stechz) from comment #7) > An other section? Bleck. What's wrong with Privacy & Security? This fits > best as a privacy option. It's weakly related in that it's an opt-in feature and we are sending data back to Mozilla. Not the typical type of "privacy" in that section. Also, it's listed first? I don't think so. Desktop has this option buried in "Advanced > General > System Defaults"
Comment 9•13 years ago
|
||
I don't think this belongs in our standard short set of prefs. How about in the tester tools pane, given that this is for people who are volunteering to help us out? For a string - "Submit performance data" is what they use on Desktop; I'd have preferred it to be clearer to _whom_ they're sending, but "Send performance data to Mozilla" is long.
Assignee | ||
Comment 10•13 years ago
|
||
There's a bug for enabling tester tools on nightly (bug 651867), but we shouldn't block for that.
Assignee | ||
Comment 11•13 years ago
|
||
We can have a follow-up bug for transferring it to feedback tools once the above bug lands, but we really could use some real data right now.
Updated•13 years ago
|
OS: Linux → All
Hardware: x86 → All
Assignee | ||
Comment 12•13 years ago
|
||
Attachment #551551 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•13 years ago
|
Attachment #551180 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #551551 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 13•13 years ago
|
||
(as it turns out, fixing the nightly feedback problem was trivial)
Assignee | ||
Comment 14•13 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/c70a97a478fe
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 15•13 years ago
|
||
Verified Fixed w/ http://hg.mozilla.org/mozilla-central/rev/08327218cb8b via http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android/1312891959/
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•