652029 - Remove WinCE code from mobile/components/build/

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ed Morley [:emorley]]

Most of the WinCE & Windows Mobile code was removed from mobile/* in bug 649078.

The only remnants left to be removed from mobile are in mobile/components/build/:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/mobile/

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from mobile/components/build/

Removes WinCE & Windows Mobile ifdefs from nsPhoneSupport.cpp & the makefile.

This leaves several nsPhoneSupport methods unused, so removes them too.

Comment 2

[Doug Turner (:dougt)]

I think you can just totally remove the nsIPhoneSupport interface.  switchTask isn't called, is it?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 527707 [details] [diff] [review]
Remove WinCE code from mobile/components/build/

Stealing review...

SwitchTask is still used on Maemo. This looks good to me

Comment 4

[Ed Morley [:emorley]]

(In reply to comment #2)
> I think you can just totally remove the nsIPhoneSupport interface.  switchTask
> isn't called, is it?

One use left of it sadly:
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser-ui.js#829

Thanks for the fast review Mark :-)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

In my queue.

Comment 6

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/8a822b2befc3

Thanks Ms2ger :-)

Comment 7

[Ed Morley [:emorley]]

http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/mobile/
...returns 0 results.

-> Verified.