Closed Bug 652029 Opened 11 years ago Closed 11 years ago

Remove WinCE code from mobile/components/build/

Categories

(Firefox for Android Graveyard :: General, defect)

All
Windows CE
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Most of the WinCE & Windows Mobile code was removed from mobile/* in bug 649078.

The only remnants left to be removed from mobile are in mobile/components/build/:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/mobile/
Removes WinCE & Windows Mobile ifdefs from nsPhoneSupport.cpp & the makefile.

This leaves several nsPhoneSupport methods unused, so removes them too.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #527707 - Flags: review?(doug.turner)
I think you can just totally remove the nsIPhoneSupport interface.  switchTask isn't called, is it?
Comment on attachment 527707 [details] [diff] [review]
Remove WinCE code from mobile/components/build/

Stealing review...

SwitchTask is still used on Maemo. This looks good to me
Attachment #527707 - Flags: review?(doug.turner) → review+
(In reply to comment #2)
> I think you can just totally remove the nsIPhoneSupport interface.  switchTask
> isn't called, is it?

One use left of it sadly:
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/browser-ui.js#829

Thanks for the fast review Mark :-)
Keywords: checkin-needed
In my queue.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/8a822b2befc3

Thanks Ms2ger :-)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Flags: in-testsuite-
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/mobile/
...returns 0 results.

-> Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.