652259 - [RTL] New Theme Style shows arrow in wrong place for opening a new tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110422 Firefox/6.0a1 Fennec/6.0a1
Device: Thunderbolt
OS: Android 2.2

1. install the arabic addon from :http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-linux-l10n/
2. set the language to arabic
3. go to www.google.com
4. open a new tab by long tapping and clicking in the first link

Expected: Arrow will be in the right order from the dialog
Actual: the Arrow is in the wrong position

Note:
1. based on testing from Bug 618989

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: arabic ss

Comment 2

[Anas Husseini [:linostar]]

Attachment: patch v1

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #2)
> Created attachment 528806 [details] [diff] [review] [review]
> patch v1

Can you check that your patch does not regress bug 605930?

Comment 4

[Anas Husseini [:linostar]]

(In reply to comment #3)
> Can you check that your patch does not regress bug 605930?

Tested. No regression.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I assume you also need to change http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/bindings/arrowbox.xml#134 ?

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 528806 [details] [diff] [review]
patch v1

I will change the code I've indicated in the previous comment to use "normal" instead of "ltr" for parity.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/664382a1d450

Comment 8

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110510 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)