Closed Bug 652297 Opened 13 years ago Closed 12 years ago

Stop trying to package MSVC DLLs in debug Windows Firefox

Categories

(Firefox Build System :: General, defect, P1)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows Server 2003
Type:
defect

Tracking

(firefox9 wontfix, firefox10 wontfix, firefox11 wontfix, firefox-esr10 wontfix)

Status:
VERIFIED FIXED
Milestone:
mozilla12
Tracking Flags:
Tracking Status
firefox9 --- wontfix
firefox10 --- wontfix
firefox11 --- wontfix
firefox-esr10 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(2 files)

(Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files [Checked in: Comment 3]
1.98 KB, patch
ted
: review+
Details | Diff | Splinter Review
(Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox [Checked in: Comment 8]
764 bytes, patch
ted
: review+
Details | Diff | Splinter Review 
See (SeaMonkey) bug 565774.
Flags: in-testsuite-
https://tbpl.mozilla.org/php/getParsedLog.php?id=8566957&full=1&branch=try
WINNT 5.2 try leak test build on 2012-01-15 09:28:26 PST for push 0f7ff1139bde
{
Error: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 40).
Error: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 41).
Error: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 42).
Error: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 43).
}
Blocks: 565774, 713132
Severity: minor → normal
Priority: -- → P1
Whiteboard: [good first bug][mentor=sgautherie]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #591739 -
        Flags: review?(ted.mielczarek)

    
  

          status-firefox10:
          --- → wontfix

          status-firefox11:
          --- → wontfix

          status-firefox9:
          --- → wontfix
Summary: Stop trying to package MSVC DLLs in debug Windows Firefox (and Fennec) → Stop trying to package MSVC DLLs in debug Windows Firefox
Whiteboard: [good first bug][mentor=sgautherie]
Target Milestone: --- → Firefox 12

        Attachment #591739 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
Comment on attachment 591739 [details] [diff] [review]
(Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/e99e0dc97746

        Attachment #591739 -
        Attachment description: (Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files → (Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files
[Checked in: Comment 3]

    
  
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
(In reply to Shane Bundy from comment #5)
Whoops, forgot this was backed out. My mistake.

    
    

    
  
(In reply to Shane Bundy from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/e99e0dc97746

This is comment 3.


(In reply to Shane Bundy from comment #6)
> Whoops, forgot this was backed out. My mistake.

This was _not_ backed out: no reason to do so.

        Attachment #592378 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
Comment on attachment 592378 [details] [diff] [review]
(Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox
[Checked in: Comment 8]

https://hg.mozilla.org/mozilla-central/rev/284bcd56f151

        Attachment #592378 -
        Attachment description: (Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox → (Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox
[Checked in: Comment 8]

    
  
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED

    
    

    
  
https://tbpl.mozilla.org/php/getParsedLog.php?id=8910023&tree=Firefox&full=1
WINNT 5.2 mozilla-central leak test build on 2012-01-28 09:14:45 PST for push 284bcd56f151

V.Fixed
Status: RESOLVED → VERIFIED
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 12 → mozilla12

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: