Stop trying to package MSVC DLLs in debug Windows Firefox

VERIFIED FIXED in Firefox 12

Status

()

Firefox
Build Config
P1
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
Firefox 12
x86
Windows Server 2003
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox9 wontfix, firefox10 wontfix, firefox11 wontfix, firefox-esr10 affected)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
See (SeaMonkey) bug 565774.
Flags: in-testsuite-
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=8566957&full=1&branch=try
WINNT 5.2 try leak test build on 2012-01-15 09:28:26 PST for push 0f7ff1139bde
{
Error: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 40).
Error: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 41).
Error: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 42).
Error: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 43).
}
Blocks: 565774, 713132
Severity: minor → normal
(Assignee)

Updated

5 years ago
Priority: -- → P1
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug][mentor=sgautherie]
(Assignee)

Comment 2

5 years ago
Created attachment 591739 [details] [diff] [review]
(Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files
[Checked in: Comment 3]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #591739 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
status-firefox10: --- → wontfix
status-firefox11: --- → wontfix
status-firefox9: --- → wontfix
Summary: Stop trying to package MSVC DLLs in debug Windows Firefox (and Fennec) → Stop trying to package MSVC DLLs in debug Windows Firefox
Whiteboard: [good first bug][mentor=sgautherie]
Target Milestone: --- → Firefox 12
Attachment #591739 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 591739 [details] [diff] [review]
(Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/e99e0dc97746
Attachment #591739 - Attachment description: (Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files → (Av1) Stop trying to package MSVC DLLs in debug Windows Firefox, Reorder XPCOM files [Checked in: Comment 3]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
Created attachment 592378 [details] [diff] [review]
(Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox
[Checked in: Comment 8]

Sorry, I forgot to check that previously.
Attachment #592378 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e99e0dc97746

Comment 6

5 years ago
(In reply to Shane Bundy from comment #5)
Whoops, forgot this was backed out. My mistake.
(Assignee)

Comment 7

5 years ago
(In reply to Shane Bundy from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/e99e0dc97746

This is comment 3.


(In reply to Shane Bundy from comment #6)
> Whoops, forgot this was backed out. My mistake.

This was _not_ backed out: no reason to do so.
Attachment #592378 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 8

5 years ago
Comment on attachment 592378 [details] [diff] [review]
(Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox
[Checked in: Comment 8]

https://hg.mozilla.org/mozilla-central/rev/284bcd56f151
Attachment #592378 - Attachment description: (Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox → (Bv1) Add '-DMOZ_DEBUG=1' too to actually stop trying to package MSVC DLLs in debug Windows Firefox [Checked in: Comment 8]
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=8910023&tree=Firefox&full=1
WINNT 5.2 mozilla-central leak test build on 2012-01-28 09:14:45 PST for push 284bcd56f151

V.Fixed
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
status-firefox-esr10: --- → affected
You need to log in before you can comment on or make changes to this bug.