652364 - Building with osxspell is broken since Bug 629734

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Nomis101]

I normally build my mozilla applications with osxspell instead of hunspell (by reverting Bug 422760). Since I've recently switched from mozilla-2.0 to mozilla-aurora, this is broken. At the end it everytime shows me:

ld: warning: ignoring file /Developer/SDKs/MacOSX10.6.sdk/System/ 
Library/Frameworks//QuickTime.framework/QuickTime, missing required 
architecture x86_64 in file 
ld: warning: could not create compact unwind for _ffi_call_unix64: 
does not use RBP or RSP based frame 
Undefined symbols for architecture x86_64: 
  "mozOSXSpell::LoadDictionariesFromDir(nsIFile*)", referenced from: 
      vtable for mozOSXSpellin mozOSXSpell.o 
ld: symbol(s) not found for architecture x86_64 
collect2: ld returned 1 exit status 
make[5]: *** [XUL] Error 1 
make[4]: *** [libs_tier_platform] Error 2 
make[3]: *** [tier_platform] Error 2 
make[2]: *** [default] Error 2 
make[1]: *** [default] Error 2 
make: *** [build] Error 2 



Its broken in mozilla-aurora and mozilla-central. I now spend a few days to find the culprit. It is the change from Bug 629734 in mozISpellCheckingEngine.idl. If I back this change out, than it builds fine again. 

The patch I used to back it out and workaround the error is:

diff --git a/extensions/spellcheck/idl/mozISpellCheckingEngine.idl b/extensions/spellcheck/idl/mozISpellCheckingEngine.idl
--- a/extensions/spellcheck/idl/mozISpellCheckingEngine.idl
+++ b/extensions/spellcheck/idl/mozISpellCheckingEngine.idl
@@ -32,20 +32,19 @@
  * and other provisions required by the GPL or the LGPL. If you do not delete
  * the provisions above, a recipient may use your version of this file under
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
 
 #include "nsISupports.idl"
 
-interface nsIFile;
 interface mozIPersonalDictionary;
 
-[scriptable, uuid(6eb307d6-3567-481a-971a-feb666b8ae72)]
+[scriptable, uuid(43987F7B-0FAA-4019-811E-42BECAC73FC5)]
 
 /**
  * This interface represents a SpellChecker.
  */
 
 interface mozISpellCheckingEngine : nsISupports {
   /**
    * The name of the current dictionary
@@ -91,19 +90,14 @@ interface mozISpellCheckingEngine : nsIS
    * check a word
    */
   boolean check(in wstring word);
 
   /**
    * get a list of suggestions for a misspelled word
    */
   void suggest(in wstring word,[array, size_is(count)] out wstring suggestions, out PRUint32 count);
-
-  /**
-   * Load dictionaries from the specified dir
-   */
-  void loadDictionariesFromDir(in nsIFile dir);
 };
 
 %{C++
 #define DICTIONARY_SEARCH_DIRECTORY "DictD"
 #define DICTIONARY_SEARCH_DIRECTORY_LIST "DictDL"
 %}

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Fix build error with osxspell.

Comment 2

[(no longer active)]

Comment on attachment 527970 [details] [diff] [review]
Fix build error with osxspell.

Review of attachment 527970 [details] [diff] [review]:

r=me.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'll land this myself.  Was going to do it last night but the tree was broken :-(

Comment 4

[Nomis101]

(In reply to comment #3)
> I'll land this myself.
Ping

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to comment #4)
> (In reply to comment #3)
> > I'll land this myself.
> Ping

Sorry, I totally lost track of this.

http://hg.mozilla.org/mozilla-central/rev/f0f14683ce7b