Closed Bug 652382 Opened 13 years ago Closed 13 years ago

Certain invalid values in initialScripts results in NS_ERROR_FILE_UNRECOGNIZED_PATH

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)

References

Details

(Whiteboard: [cz-0.9.88])

Attachments

(1 file)

If you add certain garbage to the initialScripts preferences (Global Settings > Startup > Auto-load scripts), e.g. things starting with "/" (like IRC commands), you get this for your trouble:

NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFileProtocolHandler.getFileFromURLSpec] @ <chrome://chatzilla/content/lib/js/utils.js> 1034
+ QueryInterface (function) 3 lines
+ message (string) 'Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFileProtocolHandler.getFileFromURLSpec]'
+ result (number) 2152857601
+ name (string) 'NS_ERROR_FILE_UNRECOGNIZED_PATH'
+ filename (string) 'chrome://chatzilla/content/lib/js/utils.js'
+ lineNumber (number) 1034
+ columnNumber (number) 0
+ location (object)
+ inner (object) null
+ data (object) null
+ initialize (function) 3 lines
*

We already have some defenses in place for this preference but clearly we need to enlarge the scope or add more.
This adds a try/catch around the two dangerous calls in initialScript's loading and reports the invalid item. I also made an attempt at rewording the problematic items in preferences.
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #534393 - Flags: review?(samuel)
Attachment #534393 - Flags: review?(samuel) → review+
http://hg.mozilla.org/chatzilla/rev/97c47c01d94c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.88]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: