652382 - Certain invalid values in initialScripts results in NS_ERROR_FILE_UNRECOGNIZED_PATH

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

If you add certain garbage to the initialScripts preferences (Global Settings > Startup > Auto-load scripts), e.g. things starting with "/" (like IRC commands), you get this for your trouble:

NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFileProtocolHandler.getFileFromURLSpec] @ <chrome://chatzilla/content/lib/js/utils.js> 1034
+ QueryInterface (function) 3 lines
+ message (string) 'Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFileProtocolHandler.getFileFromURLSpec]'
+ result (number) 2152857601
+ name (string) 'NS_ERROR_FILE_UNRECOGNIZED_PATH'
+ filename (string) 'chrome://chatzilla/content/lib/js/utils.js'
+ lineNumber (number) 1034
+ columnNumber (number) 0
+ location (object)
+ inner (object) null
+ data (object) null
+ initialize (function) 3 lines
*

We already have some defenses in place for this preference but clearly we need to enlarge the scope or add more.

Comment 1

[James Ross]

Attachment: Catch errors in initialScripts and update labels

This adds a try/catch around the two dangerous calls in initialScript's loading and reports the invalid item. I also made an attempt at rewording the problematic items in preferences.

Comment 2

[James Ross]

http://hg.mozilla.org/chatzilla/rev/97c47c01d94c