65253 - Profile Creation: Need a user interface for Regional Content

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect, P2)

Description

[Jaime Rodriguez, Jr.]

Creating new bug to remove Netscape Confidential information. Formerly bugzilla
64147.

Comment 1

[Jaime Rodriguez, Jr.]

We are planning on seprating the language UI from the content in Customization
Packs (aka Language Packs). When we do this, we will need to provide the user
with a means to edit their Regional Content
in Profile Manager.

Nominating for nsbeta1.


------- Additional Comments From Jaime Rodriguez, Jr. 2001-01-02 18:11 -------

Adding msanz, vishy, blee and tpringle to cc: list.

Adding nsbeta1 and intl keywords.

Comment 2

[Jaime Rodriguez, Jr.]

------- Additional Comments From Jaime Rodriguez, Jr. 2001-01-08 10:57 -------

Reassigning to Tao per Nav Triage team.


------- Additional Comments From [e-mail] 2001-01-08 11:56 -------

Hi, Jaime:


Would you like to drive the UI design first? IMO, ProfileManager, Prefs dlg, and
"View" menu should be consistent and mutual complementary.


------- Additional Comments From Jaime Rodriguez, Jr. 2001-01-08 16:56 -------

I concur with your opinion. Yup, guess I could lock down the UI stuff first . .
. fair enough.

Comment 3

[tao]

Reassing to Jaime for UI design

Comment 4

[Jaime Rodriguez, Jr.]

Vishy - I'm gonna need some help from German and Ben on this one (i.e. UI work).

Adding German and Ben to cc: list.

Comment 5

[Jaime Guerrero at iPlanet, a Sun+Netscape Alliance]

this was assigned to the WRONG jaime at Netscape.
reassigning to the reporter

Comment 6

[german]

Can somebody tell me how this is being used, ie. how often do users switch this 
setting, when do they switch and what is the trigger/motivation. It's much 
easier to design this once their is a clear understanding on these items.

Comment 7

[Jaime Rodriguez, Jr.]

Met with German on Wednesday, 02.21.01. We reviewed the feature and its future 
versioning. Addtionally, we provided him the original Language Pack doucment for 
his use. Next steps, will be for German to propose new UI specification to 
address the separation of Language and Content.

Comment 8

[german]

I have better understanding now what the separation of UI Language and Regional
content packs mean. I am now of the belief that the change of the UI Language is
probably much less frequent than that of regional packs, meaning the UI language
selection should prob be a pref which is then peristed in the profile.
Regional Content Packs however are envisioned to be changed frequently, thus I
would assume they are similar to themes, meaning we should add them to the View
menu similar to "Apply Theme". Adding them to prefs is optional. 

Comment 9

[Jaime Rodriguez, Jr.]

Reassigning to German for UI specification.

Comment 10

[Jaime Rodriguez, Jr.]

This one also needs to be fixed ASAP. 

Comment 11

[Jaime Rodriguez, Jr.]

reassigning to nhotta.

Comment 12

[Jon Rubin]

Added Asa to the cc: list.

Jaime, would you say that this bug depends on the questions in 65241 being 
resolved first?

Comment 13

[Asa Dotzler [:asa]]

I'm confused.  This bug was assigned to German for a UI specification.  A UI 
proposal (which until a few minutest ago was not publically available) has 
landed in bug 79551. The proposal has standing objections from both mpt and Ben 
Goodger. Why has this bug been handed to someone for implementation when the 
design phase has not been completed?

Comment 14

[Jaime Rodriguez, Jr.]

German - Do you want to walk people through the proposal and review process for
the design phase? I think Ben was cc:'d on all the proposals.

Comment 15

[nhottanscp]

Reassign to vishy.

Comment 16

[Viswanath Ramachandran]

jaime, I cannot commit to doing this work for mozilla0.9.1 in light of the 
points asa has raised and its too late to start this. 

Comment 17

[Jaime Rodriguez, Jr.]

Vishy - Suggest we accept German's proposal, and accpet the fix for this one, as 
MPT and others are in agreement, that this is the most likely place users would 
change the Language UI. If not here, then where?

Comment 18

[Robert Kaiser]

Jaime, as I think we want users to *be able* to switch their UI language on an
existing profile, we should also have it in prefs IMO (bug 65251).

Comment 19

[Jaime Rodriguez, Jr.]

Agreed!

Comment 20

[Jaime Rodriguez, Jr.]

This should be marked M0.9.2, not "Future".

Comment 21

[timeless]

clobbering milestone for recondisderation.

Comment 22

[Viswanath Ramachandran]

setting m0.9.2, I'll try and find the right owner in my group for this one. 

Comment 23

[Jaime Rodriguez, Jr.]

thanks vishy.

Comment 24

[[e-mail] (away - not reading bugmail)]

per mpt's comments in bug 65251:

adding related UI bugs to the dependency tree to provide better way of cross-
referencing the somewhat disparate sources of information.

Here are pointers to Tao's localization project, which will hopefully provide a 
path of enlightenment on the topic of language and regional content bundling:

Regional Content Bundling
http://www.mozilla.org/projects/l10n/mlp_regional.html

Please note that Mozilla has divided up the original language pack from en-
US.jar into en.jar (language pack), US.jar (regional content pack) and en-
XXX.jar (platform-related en-linux, en-win, ... ). Click below for the gory 
details:

L10n Packaging 
http://www.mozilla.org/projects/l10n/mlp_what2.html#chrome_files
http://www.mozilla.org/projects/l10n/mlp_packaging.html

German's UI (image references are now functional):
http://www.mozilla.org/projects/ui/communicator/framework/langcontentui/

Comment 25

[[e-mail] (away - not reading bugmail)]

vishy,

I'm the owner of a commercial tree dup - 
http://bugscape.netscape.com/show_bug.cgi?id=4942.

I'm tentatively assigning to myself.

Comment 26

[[e-mail] (away - not reading bugmail)]

Attachment: Patch #1 (cvs diff -u -w profile > bug65253-1.txt)

Comment 27

[[e-mail] (away - not reading bugmail)]

Attachment: Screenshot

Comment 28

[[e-mail] (away - not reading bugmail)]

ben, alecf, blizzard:

could you please r/sr? i18n really wants this UI modification in Beta1 - your 
help/comments are greatly appreciated! 

I believe that unlike with the "View" menu, there was a consensus on including 
region packs in the Mozilla Profile Manager...

Comment 29

[timeless]

yuck. can you please just insert it into the wizard sequence? Does ui object to 
it being in the wizard sequence?

Comment 30

[[e-mail] (away - not reading bugmail)]

timeless,

I'd be more than happy to implement whatever UI requirements the Mozilla 
community will arrive at - for starters, the current patch conforms with 
German's UI proposal. I can only hope that you've read the prior discussion 
including the (however crude) UI prototype. If so, I'm surprised why are you 
voicing you opinion only now - with the 0.9.1 branch and Beta1 on the horizon? 
I don't like the popup either, although I'm not sure, what other folks are 
thinking of a third wizard.

Comment 31

[timeless]

sorry. at the time someone or german attached a url that didn't include 
pictures. I read the url. it was useless. I didn't read the url after it got 
pictures.

Personally, i think i requested in one of these (perhaps languages and not 
content -- *shrug*) bugs that we recycle code, so if you've already done the 
'using Prefs' panel, please recycle its code into the profile manager.

Comment 32

[[e-mail] (away - not reading bugmail)]

>so if you've already done the 'using Prefs' panel, please recycle its code 
>into the profile manager

Timeless, let me repeat what I already pointed out to Gerv - I'm finding both
the form and content of the so-called "UI consensus building process" very
disturbing. I also suspect, that some of the Mozilla contributors are neither
aware, nor appreciative of i18n and l10n requirements.

Let me provide you some more factual information: although I've not read your
previous requests, I too suggested to reuse the prefs code in an internal i18n
discussion at Netscape. However, the new pref panel is not yet finished and we
are running against some hard deadlines. Would you like to help? If not, please
at least try to keep this discussion more pleasant, which would be to everyone's
benefit.

Comment 33

[timeless]

selectLang.xul
@@ -36,9 +39,30 @@
those look like tabs.

asside from that you can have an r=timeless and someone can spear me for it.  

> the form and content of the so-called "UI consensus building process"
> very disturbing.
I'd expect you're in the minority, I don't know if I could name someone who 
disagrees w/ your statement.
> I also suspect, that some of the Mozilla contributors are neither aware,
> nor appreciative of i18n and l10n requirements.
This is an accurate statement.  However just as we frustrate your work, we 
frustrate theirs.

My r= is only valid in conjunction w/ an sr= from blake, ben or someone 
who is [e-mail] -- sorry.

My comments are in bug 65251, please read them even if just to know what I have 
written.  You might also look at attachment 21647 [details] which should be suffering 
from bitrot but is probably rehabilitatable.

Comment 34

[nhottanscp]

Cc [e-mail], the change affects localization.

Comment 35

[Jaime Rodriguez, Jr.]

Sending to DanielMC for L10N approval.

Comment 36

[[e-mail] (away - not reading bugmail)]

Attachment: Partial patch to disprove the claim that tabs have been added to selectLang.xul (cvs diff -t profile > bug65253-13.txt)

Comment 37

[[e-mail] (away - not reading bugmail)]

Addressed timeless concern of unnecessary patches by attaching an expanded 
diff -t. Awaiting sr= per offline discussion with Vishy and Jaime. Working on a 
commercial-only fix, which is be more extensive, since the the /profile 
directory in the /ns tree is currently pretty bare...

Comment 38

[Ben Goodger (use ben at mozilla dot org for email)]

put rows=5 on the tree widget, and sr=ben for the FE changes. 

Do we have the spec's "friendly explanatory text" yet? Are people likely to know 
 what this means? 

Comment 39

[[e-mail] (away - not reading bugmail)]

Attachment: Patch #2 (cvs diff -u -w profile > bug65253-15.txt)

Comment 40

[[e-mail] (away - not reading bugmail)]

Attachment: Resized popup (per Ben's comment)

Comment 41

[[e-mail] (away - not reading bugmail)]

Jaime,

we still need to come up with some explanatory text. I think it's 
comprehensible as it is right now and I will proceed with the checkin, yet we 
should make it accessible for just about anyone. Especially given the broad 
audience Content Packs might cater to in the near future.

Comment 42

[[e-mail] (away - not reading bugmail)]

checked in - leaving open to solicit Jaime's feedback

Comment 43

[timeless]

sorry, you missed my point [my fault for not being explicit].
@@ -36,9 +39,30 @@
             </treerow>
           </treeitem>
^two character indentation
the stuff that i said 'looked like tabs' was certainly not 2 character 
indentation.  I don't care if they're tabs or not, they don't match the 
indentation style of that part of the file (and i'm guessing they don't match 
the rule for the file either).

Comment 44

[[e-mail] (away - not reading bugmail)]

well, you are sorry and I'm sorry :-) 

looks like the indent in the newly added part is a real mess. I've certainly 
overlooked it an wonder, how it got there in the first place...

 49  //An infinite number of monkeys hacking on an infinite number of terminals
 50  //will eventually produce the perfect browser...
 51
 52     <menulist id="regionList" flex="1">
 53           <menupopup
 54               datasources="rdf:chrome"  ref="urn:mozilla:locale:root" 
 55               sortResource="http://www.mozilla.org/rdf/chrome#name"
 56               sortDirection="ascending">
 57             <template xmlns:chrome="http://www.mozilla.org/rdf/chrome#">
 58                 <rule chrome:localeType="region">
 59                         <menuitem class="standard" uri="rdf:*" 
 60                                   
label="rdf:http://www.mozilla.org/rdf/chrome#displayName"
 61                                   
value="rdf:http://www.mozilla.org/rdf/chrome#name"/>
 62                 </rule>
 63             </template>
 64           </menupopup>
 65     </menulist>       

Comment 45

[Alec Flett]

for amusement only, I'll add that I too find it disturbing :)

Comment 46

[[e-mail] (away - not reading bugmail)]

Attachment: Patch #3

Comment 47

[[e-mail] (away - not reading bugmail)]

Oh God, looks like this patch has been made under an unlucky star. Naoki just 
pointed out that we should tag the default content pack in Mozilla (read 
mark "US Region" as a content pack). And it also seems that the previous patch 
didn't contain the changes from selectLang.js - maybe the gremlins ate it.

Anyhow, here is a second installment in case we get the approval to sneak it 
into Beta1. It also addresses the indention issues in selectLang.xul.

Comment 48

[[e-mail] (away - not reading bugmail)]

Attachment: Patch #4 - fixes indention in selectLang.js

Comment 49

[[e-mail] (away - not reading bugmail)]

moving back to 0.9.1, I'll try to get PDT's approval to get this second 
installment into Beta1

Comment 50

[Alec Flett]

sr=alecf, looks fine

Comment 51

[nhottanscp]

r=nhotta

Comment 52

[[e-mail] (away - not reading bugmail)]

Attachment: Patch #5, per ftang's suggestion supressing whitespace changes for PDT review (cvs diff -u -b profile > bug65253-31.txt)

Comment 53

[Jaime Rodriguez, Jr.]

Adding jon rubin to cc: list.

Comment 54

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 55

[[e-mail] (away - not reading bugmail)]

closing at last - thanks everyone!

Comment 56

[Grace Bush]

Jon,
would you verify this please?

thanks

Comment 57

[Jon Rubin]

Verified on WinMe-Ja, Ja 060713-0.9.1.

Comment 58

[Jon Rubin]

Bugscape 6828 has been added for problem where selected region does not take
affect after profile creation.