652557 - Media file display names should use decodeURIComponent instead of decodeURI (Port Bug 494328)

Status: RESOLVED FIXED

(SeaMonkey :: Feed Discovery and Preview, enhancement)

Description

[Philip Chee]

From Bug 494328 Comment 0:

> Just nitpicking really, since we're only displaying the filename of the media
> file, there are no special characters to watch out for.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> Open a podcast feed with files named like "Episode #4", this will be encoded in
> the XML as "Episode%20%234"
> Actual Results:  
> Will display as "Episode %234"
> 
> Expected Results:  
> Should display as "Episode #4"

Comment 1

[Philip Chee]

Attachment: Patch v1.0 use decodeURIComponent()

Comment 2

[[e-mail]]

Comment on attachment 528119 [details] [diff] [review]
Patch v1.0 use decodeURIComponent()

Review of attachment 528119 [details] [diff] [review]:

::: suite/feeds/src/FeedWriter.js
@@ +557,5 @@
     var url = makeURI(aURL);
 
     if ((url instanceof Components.interfaces.nsIURL) && url.fileName)
+      return decodeURIComponent(url.fileName);
+    return decodeURIComponent(aURL);

I can see that it's right to decodeURIComponent on the fileName component, but I'm not wholly convinced that we should do it on the URL itself...

Comment 3

[Philip Chee]

Attachment: Patch v1.1 fixup the url.fileName only

> Review of attachment 528119 [details] [diff] [review]:
> 
> ::: suite/feeds/src/FeedWriter.js
> @@ +557,5 @@
>      var url = makeURI(aURL);
> 
>      if ((url instanceof Components.interfaces.nsIURL) && url.fileName)
> +      return decodeURIComponent(url.fileName);
> +    return decodeURIComponent(aURL);
> 
> I can see that it's right to decodeURIComponent on the fileName component, but
> I'm not wholly convinced that we should do it on the URL itself...
Yes. I wondered why Firefox bothered doing this as well.
Fixed.

Comment 4

[Philip Chee]

Pushed:
http://hg.mozilla.org/comm-central/rev/c3eb66f60c2b
http://hg.mozilla.org/releases/comm-2.0/rev/f1b7464a4fd7