Closed Bug 652666 Opened 9 years ago Closed 9 years ago

ltm is not defined

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5
Tracking Status
firefox5 --- fixed

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Keywords: regression, Whiteboard: [verified in services])

Attachments

(1 file)

Ooops, a left-over from bug 648338:

1303768364633	Store.Prefs	WARN	Encountered exception: ltm is not defined JS Stack trace: PrefStore__setAllPrefs([object Object])@prefs.js:169 < PrefStore_update([object Object])@prefs.js:214 < Store_applyIncoming([object Object])@engines.js:229 < applyIncomingBatch([object Array])@engines.js:213 < doApplyBatch()@engines.js:628 < ([object Object])@engines.js:720 < ()@record.js:813 < Channel_onDataAvail([object XPCWrappedNative_NoHelper],null,[object XPCWrappedNative_NoHelper],12031,1439)@resource.js:587
Keywords: regression
For STR tracking,
 i hit this error when choosing the sync option: Replace all other options with this computer's data.   

This was done against Aurora builds:
Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110424 Firefox/5.0a2
Attached patch v1Splinter Review
Fix + test.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #528256 - Flags: review?(rnewman)
Tony's STRs are incomplete. More reliable STRs:

* Select persona on computer A
* Sync computer A
* Sync computer B
* Observe error on computer B
Comment on attachment 528256 [details] [diff] [review]
v1

Looks good, tests pass!
Attachment #528256 - Flags: review?(rnewman) → review+
Pushed, so we can get builds to QA.

  https://hg.mozilla.org/services/services-central/rev/7430b446a866

Tony and Tracy, TBPL link for ya:

  http://tbpl.mozilla.org/?tree=Services-Central&rev=7430b446a866
Whiteboard: [fixed in services]
Comment on attachment 528256 [details] [diff] [review]
v1

As Tony points out in comment 1, this affects Aurora. We definitely need to land this fix there.
Attachment #528256 - Flags: approval-mozilla-aurora?
verified in s-c builds of 1303795082
Whiteboard: [fixed in services] → [verified in services]
http://hg.mozilla.org/mozilla-central/rev/7430b446a866
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Attachment #528256 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Philipp is out today, so I will land this on Aurora momentarily, along with Bug 618052.
Setting target milestone to mozilla5, given that we also landed on Aurora.
Target Milestone: mozilla6 → mozilla5
Verified fix on aurora:  

 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110428 Firefox/5.0a2
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.