652666 - ltm is not defined

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Ooops, a left-over from bug 648338:

1303768364633	Store.Prefs	WARN	Encountered exception: ltm is not defined JS Stack trace: PrefStore__setAllPrefs([object Object])@prefs.js:169 < PrefStore_update([object Object])@prefs.js:214 < Store_applyIncoming([object Object])@engines.js:229 < applyIncomingBatch([object Array])@engines.js:213 < doApplyBatch()@engines.js:628 < ([object Object])@engines.js:720 < ()@record.js:813 < Channel_onDataAvail([object XPCWrappedNative_NoHelper],null,[object XPCWrappedNative_NoHelper],12031,1439)@resource.js:587

Comment 1

[Tony Chung [:tchung]]

For STR tracking,
 i hit this error when choosing the sync option: Replace all other options with this computer's data.   

This was done against Aurora builds:
Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110424 Firefox/5.0a2

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Fix + test.

Comment 3

[Philipp von Weitershausen [:philikon]]

Tony's STRs are incomplete. More reliable STRs:

* Select persona on computer A
* Sync computer A
* Sync computer B
* Observe error on computer B

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 528256 [details] [diff] [review]
v1

Looks good, tests pass!

Comment 5

[Richard Newman [:rnewman]]

Pushed, so we can get builds to QA.

  https://hg.mozilla.org/services/services-central/rev/7430b446a866

Tony and Tracy, TBPL link for ya:

  http://tbpl.mozilla.org/?tree=Services-Central&rev=7430b446a866

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 528256 [details] [diff] [review]
v1

As Tony points out in comment 1, this affects Aurora. We definitely need to land this fix there.

Comment 7

[Tracy Walker [:tracy]]

verified in s-c builds of 1303795082

Comment 8

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/7430b446a866

Comment 9

[Richard Newman [:rnewman]]

Philipp is out today, so I will land this on Aurora momentarily, along with Bug 618052.

Comment 10

[Richard Newman [:rnewman]]

Landed on Aurora:

http://hg.mozilla.org/mozilla-aurora/rev/4f81374b1ffc

Comment 11

[Richard Newman [:rnewman]]

Setting target milestone to mozilla5, given that we also landed on Aurora.

Comment 12

[Tony Chung [:tchung]]

Verified fix on aurora:  

 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0a2) Gecko/20110428 Firefox/5.0a2