Closed Bug 652939 Opened 9 years ago Closed 9 years ago

folderpane_splitter in rtl mode doubled

Categories

(Thunderbird :: Theme, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 5.0b1

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In rtl mode the folderpane_splitter has two lines, see https://bugzilla.mozilla.org/show_bug.cgi?id=646032#c29.
Attached patch Splitter patchSplinter Review
Patch fixing the doubled border. I also checked vertical view, Address book and Composer. This is the only part who needs a fix.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #528416 - Flags: review?(bwinton)
Comment on attachment 528416 [details] [diff] [review]
Splitter patch

Review of attachment 528416 [details] [diff] [review]:

It seems to work, so I'll give it an r=me, but…

::: mail/themes/qute/mail/mailWindow1-aero.css
@@ +26,3 @@
 }
 
+#folderpane_splitter[state="collapsed"]:hover:-moz-locale-dir(ltr) {

Wouldn't it be easier/more correct to change these to -moz-border-start and -moz-border-end?
Attachment #528416 - Flags: review?(bwinton) → review+
Yes this would be better and this bug wouldn't be needed, but as stated some lines above:

/* Until Bug 621351 is fixed we need border-right and border-left in
 * combination with -moz-locale-dir instead of -moz-border-end and
 * -moz-border-start for -moz-transition
 */
Keywords: checkin-needed
Hah!  I even filed that bug…  :)

Okay, sounds good to me, then.

Thanks,
Blake.
Checked in: http://hg.mozilla.org/comm-central/rev/efb1f38f68cf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in before you can comment on or make changes to this bug.