652939 - folderpane_splitter in rtl mode doubled

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

In rtl mode the folderpane_splitter has two lines, see https://bugzilla.mozilla.org/show_bug.cgi?id=646032#c29.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Splitter patch

Patch fixing the doubled border. I also checked vertical view, Address book and Composer. This is the only part who needs a fix.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 528416 [details] [diff] [review]
Splitter patch

Review of attachment 528416 [details] [diff] [review]:

It seems to work, so I'll give it an r=me, but…

::: mail/themes/qute/mail/mailWindow1-aero.css
@@ +26,3 @@
 }
 
+#folderpane_splitter[state="collapsed"]:hover:-moz-locale-dir(ltr) {

Wouldn't it be easier/more correct to change these to -moz-border-start and -moz-border-end?

Comment 3

[Richard Marti (:Paenglab)]

Yes this would be better and this bug wouldn't be needed, but as stated some lines above:

/* Until Bug 621351 is fixed we need border-right and border-left in
 * combination with -moz-locale-dir instead of -moz-border-end and
 * -moz-border-start for -moz-transition
 */

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Hah!  I even filed that bug…  :)

Okay, sounds good to me, then.

Thanks,
Blake.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/efb1f38f68cf