Closed Bug 653080 Opened 13 years ago Closed 13 years ago

intermittent mochitest-browser-chrome leak of 2 domwindows opened by browser_tabview_bug597980.js

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 11

People

(Reporter: glandium, Assigned: philor)

References

Details

(Keywords: intermittent-failure, memory-leak) 

It doesn't seem to be one of the numerous mochitest-browser-chrome leaks on file.
So it looks like tbpl doesn't want to send a message here.

So, the error log is:
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox&errorparser=unittest&logfile=1303890908.1303895406.16869.gz&buildtime=1303890908&buildname=Rev3%20WINNT%205.1%20mozilla-central%20debug%20test%20mochitest-other&fulltext=1

nsTraceRefcntImpl::DumpStatistics: 1224 entries
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 2164643 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1717 instances of AtomImpl with size 20 bytes each (34340 bytes total)
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of BackstagePass with size 24 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 5 instances of BodyRule with size 16 bytes each (80 bytes total)
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of CalculateFrecencyFunction with size 12 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 5 instances of Connection with size 112 bytes each (560 bytes total)

leak starts with:

Leaked URLs:
  file:///C:/talos-slave/test/build/firefox/omni.jar
  chrome://browser/content/safebrowsing/report-phishing-overlay.xul
  http://mochi.test:8888/
  http://127.0.0.1/
  http://127.0.0.1/
  http://127.0.0.1:8888/
  http://127.0.0.1:8888/
  http://test/
  http://test/
  http://mochi.test:8888/
  http://example.org/
  http://example.org/
  http://test1.example.org/
  http://test1.example.org/
  http://test2.example.org/
  http://test2.example.org/
  http://sub1.test1.example.org/
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1311778015.1311782569.15038.gz

leak analyzer says:
(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1311752670.1311757192.10751.gz

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1311887092.1311891660.15396.gz

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)
Blocks: 438871
Keywords: mlk
OS: Windows XP → All
Whiteboard: [orange]
Rev3 Fedora 12x64 mozilla-inbound debug test mochitest-other [testfailed]
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1313319369.1313322811.5955.gz
http://tbpl.mozilla.org/leak-analysis/?id=1313319369.1313322811.5955.gz&tree=Mozilla-Inbound

chrome://mochitests/content/chrome/dom/ipc/tests/test_process_error.xul leaked 1 DOMWINDOW(s)
(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)
(In reply to Ed Morley [:edmorley] from comment #169)
> http://tbpl.allizom.org/php/getParsedLog.php?id=6055750

Rev3 WINNT 6.1 mozilla-inbound debug test mochitest-other on 2011-08-21 03:12:02 PDT for push 857f058efa56

http://tbpl.mozilla.org/leak-analysis/?id=1313921522.1313925857.20849.gz&tree=Mozilla-Inbound gives:

chrome://mochitests/content/chrome/dom/ipc/tests/test_process_error.xul leaked 1 DOMWINDOW(s)

In other words, this one doesn't belong on this bug report.

(In reply to Ed Morley [:edmorley] from comment #168)
> http://tbpl.allizom.org/php/getParsedLog.php?id=6049408
> http://tbpl.allizom.org/php/getParsedLog.php?id=6050117

Rev3 MacOSX Snow Leopard 10.6.2 mozilla-inbound debug test mochitest-other on 2011-08-20 05:56:03 PDT for push 279d6114667d
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-inbound debug test mochitest-other on 2011-08-20 07:28:59 PDT for push 279d6114667d

There are actually three for this combination, with:

http://tbpl.mozilla.org/leak-analysis/?id=1313844963.1313849279.11301.gz&tree=Mozilla-Inbound giving:

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)

http://tbpl.mozilla.org/leak-analysis/?id=1313850539.1313854791.27884.gz&tree=Mozilla-Inbound gives:

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)

http://tbpl.mozilla.org/leak-analysis/?id=1313855039.1313859336.5892.gz&tree=Mozilla-Inbound gives:

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)

> http://tbpl.allizom.org/php/getParsedLog.php?id=6050014

Rev3 MacOSX Snow Leopard 10.6.2 mozilla-inbound debug test mochitest-other on 2011-08-20 07:14:59 PDT for push 4d3de57cf813

http://tbpl.mozilla.org/leak-analysis/?id=1313849699.1313853978.25128.gz&tree=Mozilla-Inbound

(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)

So these all belong here.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314000780.1314005027.2833.gz
(unknown) leaked 4 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/toolkit/mozapps/plugins/tests/browser_bug435788.js leaked 2 DOMWINDOW(s)
(unknown) leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
https://tbpl.mozilla.org/php/getParsedLog.php?id=6502636&tree=Mozilla-Inbound
Rev3 MacOSX Leopard 10.5.8 mozilla-inbound debug test mochitest-other on 2011-09-22 09:02:53 PDT for push 502f2bd2c229

TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 2073059 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of AsyncStatement with size 48 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1702 instances of AtomImpl with size 20 bytes each (34040 bytes total)
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of BackstagePass with size 24 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 1 instance of BasicCanvasLayer with size 324 bytes
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 2 instances of BasicContainerLayer with size 340 bytes each (680 bytes total)

(unknown) leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/inspector/browser_inspector_registertools.js leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
Blocks: 678830
https://tbpl.mozilla.org/?tree=Try&rev=587bd6d86427

(unknown) leaked 2 DOMWINDOW(s)
chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)
As I was pasting those last few, I started wondering how long it would take to notice if someone landed a new and non-intermittent browser-chrome leak of the world.

Turns out, about that long, since someone did.
Pretty sure https://tbpl.mozilla.org/php/getParsedLog.php?id=7720044&tree=Mozilla-Inbound brings us back to just the normal noises, though.
There seems to be a fairly frequent leak of 5056579 bytes.  Or at least, looking back at the last few pushes on inbound I see three instances of this.  That seems kind of bad. One recent 2-4mb intermittent leak we had turned out to be a cycle collector problem.
Yeah, those retriggers were because I don't really believe that the recent Linux64 ones we've been throwing in here are the same leak as the mostly-Mac one we just ignore.
But for some reason the script from bug 538462 comment 16 (which is what tbpl's leak analysis runs when it works, which it never seems to anymore) doesn't seem to work on browser-chrome anymore - on both one of the failing runs and one of the green runs, it correctly claims no domwindows were leaked in any of the other hunks of mochitest-other, but claims that pretty much every domwindow opened in browser-chrome was leaked, even though by looking at the log you can see the "--DOMWINDOW == 647 (0xe729eb8) [serial = 9219] [outer = (nil)] [url = about:blank]" lines it should also be seeing.
That's bad.  Do you want to file a bug on that or shall I?  Though I'm not sure what component it would be.
Which "that"? tbpl doesn't work? Bug 699711. Recruit a tbpl developer who could blindly tell IT what to look for without access to the server, to debug that? We don't have a component for that. A script roc tossed off a couple of years ago doesn't work anymore? Not for that either, I don't think. I don't know why it doesn't work? There's certainly no component for things I don't know, bug numbers are cheap but not that cheap.
Depends on: 711907
(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> leak analyzer says:
> (unknown) leaked 4 DOMWINDOW(s)
> chrome://mochitests/content/browser/browser/base/content/test/tabview/
> browser_tabview_bug597980.js leaked 2 DOMWINDOW(s)

What I can't quite remember is why we then pretty much ignored that. I pushed the tip of m-c to try, got 4/20 leaks on Linux64 and 1/20 leaks on 10.6, and pushed disabling that test, and got 0/21 and 0/21.

https://hg.mozilla.org/integration/mozilla-inbound/rev/582df079dff0 with rs=ttaubert, who we never even involved with this tabview-smelling bug.

If you think you see this bug after that is merged to wherever you are seeing it, you are wrong. Nobody knows what the first three were, nobody knows what most of the last 700 were, but we used this as a dumping-ground for unexamined browser-chrome leaks for too long. Get leak-analysis to work or write a working script to do it manually (or if you're pathetic like me, use tbpl.swatinem.de, since it doesn't seem to be broken), and file new bugs for things which are not this.
Assignee: nobody → philringnalda
Target Milestone: --- → Firefox 11
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/582df079dff0

Closing according to comment 698.

If you hit leaks, please file separate bugs specified the exact specifics of the leak.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: intermittent mochitest-browser-chrome leak → intermittent mochitest-browser-chrome leak of 2 domwindows opened by browser_tabview_bug597980.js
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.