653106 - Port |Bug 572463 - Prototype urlclassifier/safe browsing client code in JS| to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Package nsUrlClassifierHashCompleter.js, except on MOZILLA_5_0_BRANCH [Checked in: Comment 2]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 528584 [details] [diff] [review]
(Av1) Package nsUrlClassifierHashCompleter.js, except on MOZILLA_5_0_BRANCH
[Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/7684d92c8e42

Comment 3

[Serge Gautherie (:sgautherie)]

Arf, I assumed SM needed this (as is) as FF and TB include this file, but I was wrong :-(

nsUrlClassifierHashCompleter.js is in (m-c)/toolkit/components/url-classifier/,
which is built with MOZ_URL_CLASSIFIER only,
which is usually (automatically) enabled with MOZ_SAFE_BROWSING.

http://mxr.mozilla.org/comm-central/search?string=MOZ_SAFE_BROWSING%3D&case=1&find=%2Fconfvars%5C.sh%24
FF and TB enable the latter, but not SM (yet).

Should I file a bug to investigate enabling Safe Browsing? (Or what's the plan/status?)

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) SeaMonkey needs |ifdef MOZ_URL_CLASSIFIER| (ftb) [Checked in: Comment 7]

Untested, but should be it.

Comment 5

[Robert Kaiser]

(In reply to comment #3)
> Should I file a bug to investigate enabling Safe Browsing? (Or what's the
> plan/status?)

I think a bug is filed, just nobody working on it. And some people think the feature itself is controversial - I was always for including it if someone has the time, but some people don't want us to block anything, if even it's known malware-installing sites.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> I think a bug is filed

I filed bug 653605, to be sure.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 528835 [details] [diff] [review]
(Bv1) SeaMonkey needs |ifdef MOZ_URL_CLASSIFIER| (ftb)
[Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/10c820cd498b

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1305438151.1305441945.18430.gz&fulltext=1
Linux comm-central-trunk build on 2011/05/14 22:42:31
{
Warning: package error or possible missing or unnecessary file: bin/components/nsUrlClassifierHashCompleter.js (package-manifest, 294).
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1305448015.1305451047.25033.gz&fulltext=1
Linux comm-central-trunk build on 2011/05/15 01:26:55

V.Fixed.