653605 - Add MOZ_SAFE_BROWSING=1 (safe browsing (anti-phishing)) to SeaMonkey

Status: RESOLVED DUPLICATE of bug 1135604

(SeaMonkey :: Build Config, enhancement)

Description

[Serge Gautherie (:sgautherie)]

Bug 653106 comment 3:
{
Serge Gautherie (:sgautherie)      2011-04-28 06:50:37 PDT

nsUrlClassifierHashCompleter.js is in (m-c)/toolkit/components/url-classifier/,
which is built with MOZ_URL_CLASSIFIER only,
which is usually (automatically) enabled with MOZ_SAFE_BROWSING.

http://mxr.mozilla.org/comm-central/search?string=MOZ_SAFE_BROWSING%3D&case=1&find=%2Fconfvars%5C.sh%24
FF and TB enable the latter, but not SM (yet).
}

I don't know this feature, I guess there's more work to do than just adding this configure option.
Yet, I'm assuming that there's hope for SM, as FF (browser) and TB (mailnews) already have it (working).


Bug 653106 comment 5:
{
Robert Kaiser      2011-04-28 07:41:21 PDT

And some people think the
feature itself is controversial - I was always for including it if someone has
the time, but some people don't want us to block anything, if even it's known
malware-installing sites.
}

Hopefully, this feature can/could be enabled/disabled at runtime.


Ftr,
I assume http://www.mozilla.com/en-US/firefox/phishing-protection/ is this feature,
and that this bug is +/- a duplicate of bug 477718, but as the latter wasn't initially filed with much details...

Comment 1

[Robert Kaiser]

(In reply to comment #0)
> I don't know this feature, I guess there's more work to do than just adding
> this configure option.

There might be some UI we need for it, esp. in terms of a pref for people to turn it off.

> Yet, I'm assuming that there's hope for SM, as FF (browser) and TB (mailnews)
> already have it (working).

It might not bee too hard to get it working, yes.

> Ftr,
> I assume http://www.mozilla.com/en-US/firefox/phishing-protection/ is this
> feature,

Yes, that's it. And bug 477718 is probably the bigger picture of that, yes.

Comment 3

[Serge Gautherie (:sgautherie)]

MOZ_SAFE_BROWSING=1 enables:
1- MOZ_URL_CLASSIFIER=1, which is the Toolkit component: done by itself in bug 738884 ftb.
2- application support code: to be coded in bug 477718.

*****

At last, we will have to sort out what we can/want to do about:

(In reply to Benjamin Smedberg  [:bsmedberg] from bug 738884 comment #3)
> There is no effect unless you also set browser.safebrowsing.malware.enabled.
> I don't know whether you need a specific agreement with Google to do that or
> not.

http://mxr.mozilla.org/comm-central/search?string=browser.safebrowsing.malware.enabled&case=1

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> http://mxr.mozilla.org/comm-central/search?string=browser.safebrowsing.
> malware.enabled&case=1

Ftr, there are 2 preferences: 1 for phishing and 1 for malware:
http://mxr.mozilla.org/comm-central/search?string=safebrowsing\..*enabled&regexp=1&case=1

Comment 5

[Philip Chee]

We now build SeaMonkey with safe-browsing unconditionally. => WONTFIX.

Comment 6

[Philip Chee]

Forwarding to Bug 1135604 where I'm adding Add MOZ_SAFE_BROWSING=1 to confvars.sh