653263 - XML bug files do not contain fields whose value evaluates to "false"

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

Due to this TT bug https://rt.cpan.org/Public/Bug/Display.html?id=9802 (closed as wontfix, unfortunately), if a field has value 0 or the empty string, then FOREACH doesn't loop using this value. This means that fields such as everconfirmed may be missing from the XML file if the bug is unconfirmed. My patch fixes this problem.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 528718 [details] [diff] [review]
patch, v1

Review of attachment 528718 [details] [diff] [review]:

Hey, that's pretty clever!

On checkin, instead of just listing the RT bug id, could you give the full URL? It's not so easy to find bugs in RT just by their id.

Comment 2

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/show.xml.tmpl
Committed revision 7797.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified template/en/default/bug/show.xml.tmpl
Committed revision 7583.

Comment 3

[Gervase Markham [:gerv]]

Side-effects from this change (the insertion of empty elements for blank fields) caused bug 656543. Is a change in the form of the XML output (which is an interface) appropriate for a stable branch?

Gerv