Closed
Bug 653263
Opened 13 years ago
Closed 13 years ago
XML bug files do not contain fields whose value evaluates to "false"
Categories
(Bugzilla :: Bug Import/Export & Moving, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
857 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
Due to this TT bug https://rt.cpan.org/Public/Bug/Display.html?id=9802 (closed as wontfix, unfortunately), if a field has value 0 or the empty string, then FOREACH doesn't loop using this value. This means that fields such as everconfirmed may be missing from the XML file if the bug is unconfirmed. My patch fixes this problem.
Attachment #528718 -
Flags: review?(mkanat)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 528718 [details] [diff] [review] patch, v1 Review of attachment 528718 [details] [diff] [review]: Hey, that's pretty clever! On checkin, instead of just listing the RT bug id, could you give the full URL? It's not so easy to find bugs in RT just by their id.
Attachment #528718 -
Flags: review?(mkanat) → review+
|
|
||
Updated•13 years ago
|
Flags: approval4.0+
Flags: approval+
|
Assignee | |
Comment 2•13 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/bug/show.xml.tmpl Committed revision 7797. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/ modified template/en/default/bug/show.xml.tmpl Committed revision 7583.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 3•13 years ago
|
||
Side-effects from this change (the insertion of empty elements for blank fields) caused bug 656543. Is a change in the form of the XML output (which is an interface) appropriate for a stable branch? Gerv
You need to log in
before you can comment on or make changes to this bug.
Description
•