importxml.pl complains if an open bug has the resolution field set to ''

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Bug Import/Export & Moving
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

({regression})

4.0.2
Bugzilla 4.0
regression
Bug Flags:
approval +
approval4.2 +
approval4.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
With bug 653263, the resolution field is now always present in the XML file, even for open bugs, and importxml.pl now complains that we tried to set a resolution for this bug. The reason is that importxml.pl checks if the resolution field is defined, not set to something. It should treat an empty resolution the same way as a missing resolution.
(Assignee)

Comment 1

6 years ago
Created attachment 565012 [details] [diff] [review]
patch, v1
Attachment #565012 - Flags: review?(dkl)
Comment on attachment 565012 [details] [diff] [review]
patch, v1

Review of attachment 565012 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl
Attachment #565012 - Flags: review?(dkl) → review+
(Assignee)

Updated

6 years ago
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 3

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified importxml.pl
Committed revision 7974.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified importxml.pl
Committed revision 7940.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified importxml.pl
Committed revision 7651.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.