The default bug view has changed. See this FAQ.

Add disk image (DMG) background for non-official branding OS X downloads

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Theme
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Dolske, Assigned: shorlander)

Tracking

unspecified
Firefox 7
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Downloading the OS X for a "Firefox" (stable) build gives you a nice background in the Finder window:

http://mxr.mozilla.org/mozilla-central/source/browser/branding/official/background.png

(Note important arrow image that indicates one should drag the app to the applications folder link.)


For our other branding flavors, it's just a blank image. It's ugly.

http://mxr.mozilla.org/mozilla-central/source/browser/branding/unofficial/background.png
http://mxr.mozilla.org/mozilla-central/source/browser/branding/aurora/background.png
http://mxr.mozilla.org/mozilla-central/source/browser/branding/nightly/background.png

We should at least use the nice background from the official/ branding sans wordmark. Bonus for putting the appropriate workmark into place. Hopefully the original artwork for that exists somewhere?
(Reporter)

Comment 1

6 years ago
(The icon for the DMG itself is also wrong, but bug 649526 looks to be taking care of that)
For Nightly and Aurora we should be using stars :)  That way you get to drag the planet around in it's correct solar context!

Comment 3

6 years ago
Created attachment 529095 [details]
Aurora DMG Background

Comment 4

6 years ago
Created attachment 529096 [details]
Nightly DMG Background

Comment 5

6 years ago
Enjoy! :)
<3
(Reporter)

Comment 7

6 years ago
Just for completeness's sake, can we get a simple version for the "unofficial" branding? Looks like it doesn't even need a wordmark, going from what we did with splash.bmp...

http://mxr.mozilla.org/mozilla-central/source/browser/branding/unofficial/splash.bmp

[Not sure if we'll even be using this branding flavor in the future, it used to be for the park-named alpha releases. But I'm assuming it should be trivial enough to make a plain/bland/mspaint version.]
I tried doing the obvious and replacing the existing background.pngs with those files, and for some reason the DMG I got from a "make package" still didn't include them (even after a clobber). I'm not sure what's going on with that.
(Assignee)

Comment 9

6 years ago
(In reply to comment #8)
> I tried doing the obvious and replacing the existing background.pngs with those
> files, and for some reason the DMG I got from a "make package" still didn't
> include them (even after a clobber). I'm not sure what's going on with that.

Probably a problem with the dsstore file. Looks like the one in the Nightly directory is still referencing DeerPark. Not sure how those were made to being with. Probably manually created by editing a DMG then copied over?
(Assignee)

Comment 10

6 years ago
Created attachment 531661 [details] [diff] [review]
Update DMG Background WIP

This patch updates the background image and the dsstore file. Only tested on 10.6.
Attachment #531661 - Flags: feedback?(gavin.sharp)
Comment on attachment 531661 [details] [diff] [review]
Update DMG Background WIP

This looks great on 10.6, but doesn't work on 10.5.
Attachment #531661 - Flags: feedback?(gavin.sharp) → feedback-
(Assignee)

Comment 12

6 years ago
Created attachment 531730 [details] [diff] [review]
Update DMG Background WIP - 02

Updated to work on 10.5
Attachment #531661 - Attachment is obsolete: true
Attachment #531730 - Flags: feedback?(gavin.sharp)
Comment on attachment 531730 [details] [diff] [review]
Update DMG Background WIP - 02

There is some weirdness on 10.5 if hidden files are visible (scrollbars appear), but that's not a major issue.

The background and the icon kind of blend together to some degree, which is a bit odd, but apparently the icon will be changing to work better in that case. I didn't check that the alignment was pixel perfect, but this is certainly better than the current setup :)
Attachment #531730 - Flags: feedback?(gavin.sharp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f04f67e0b5fe
http://hg.mozilla.org/mozilla-central/rev/f04f67e0b5fe
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → shorlander
Hardware: x86 → All
Target Milestone: --- → Firefox 7
Verified fixed on:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0a1) Gecko/20110707 Firefox/8.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.