Last Comment Bug 653782 - "Assertion failure: JS_IsArrayObject(cx, scx->replacer),"
: "Assertion failure: JS_IsArrayObject(cx, scx->replacer),"
: assertion, regression, testcase
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- critical (vote)
: mozilla6
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: jsfunfuzz
  Show dependency treegraph
Reported: 2011-04-29 11:27 PDT by Gary Kwong [:gkw] [:nth10sd]
Modified: 2011-05-10 15:13 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch and test (10.17 KB, patch)
2011-04-29 12:27 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
paul.biggar: review+
Details | Diff | Splinter Review

Description User image Gary Kwong [:gkw] [:nth10sd] 2011-04-29 11:27:11 PDT

asserts js debug shell on TM changeset 3dd6ec45084c without -m nor -j at:

Assertion failure: JS_IsArrayObject(cx, scx->replacer),

(part of backtrace):

#2  0x081d4335 in JS_Assert (s=0x83824c4 "JS_IsArrayObject(cx, scx->replacer)", file=0x838242c "/home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/json.cpp", ln=445)
    at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/jsutil.cpp:89
#3  0x0813c540 in JO (cx=0x845c098, obj=0xf750e138, scx=0xffffc0fc) at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/json.cpp:445
#4  0x0813ce0b in Str (cx=0x845c098, v=..., scx=0xffffc0fc) at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/json.cpp:628
#5  0x0813d83a in js_Stringify (cx=0x845c098, vp=0xf76e4060, replacer=0xf7502118, space=..., sb=...) at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/json.cpp:783
#6  0x0813b925 in js_json_stringify (cx=0x845c098, argc=2, vp=0xf76e4060) at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/json.cpp:145
#7  0x0810fd68 in js::CallJSNative (cx=0x845c098, native=0x813b82d <js_json_stringify(JSContext*, uintN, js::Value*)>, argc=2, vp=0xf76e4060)
    at /home/fuzz1/Desktop/jsfunfuzz-dbg-32-tm-68358-3dd6ec45084c/compilePath/js/src/jscntxtinlines.h:277
Comment 1 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-04-29 12:27:10 PDT
Created attachment 529171 [details] [diff] [review]
Patch and test

Any case where the second argument to JSON.stringify is an object that's not an array and isn't callable will trigger this.  Stupid mistake on my part.
Comment 2 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-04-29 14:07:14 PDT
Comment on attachment 529171 [details] [diff] [review]
Patch and test

Gonna try for a faster review on IRC to fix the regression faster, but if not, shouldn't be a huge problem.
Comment 3 User image Paul Biggar 2011-05-04 07:02:55 PDT
Comment on attachment 529171 [details] [diff] [review]
Patch and test

Review of attachment 529171 [details] [diff] [review]:

Looks good.
Comment 4 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-05-04 21:34:48 PDT

I also mis-tagged the following revision as being associated with this bug in its commit message:

That's actually (drumroll please)...bug 653872.  (Note the last three digits of that bug and this one.)  Sigh.
Comment 5 User image Chris Leary [:cdleary] (not checking bugmail) 2011-05-10 15:13:45 PDT
cdleary-bot mozilla-central merge info:

Note You need to log in before you can comment on or make changes to this bug.