653876 - [bedrock] Figure out localizable images

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect, P1)

Description

[Fred Wenzel [:wenzel]]

In the context of localizable content blocks, we need a way to allow image localization *without* the localizer needing to upload an image to the main media/ directory.

This could be as simple as having a bunch of symlinks underneath /media/img/l10n:
de/ -> /templates/l10n/de/media/img
fr/ -> ...

That'd allow Apache to serve these images without config changes, while keeping the localizers' work confined to their directory on SVN.

We'd need to add a helper though that returns the correct URL depending on if the image exists in the translation directory or not.

Whacha think?

Comment 1

[James Long (:jlongster)]

Do we still need something like this? Pascal has never mentioned it. Although we haven't really localized a lot of bedrock yet. Seems like we could add a symlink at /media/img/l10n to /locale and be done with it. Do we want to allow people to host stuff on mozilla.org like that though?

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

The main need for localized images are screenshots, usually the localizer provides them .

Comment 3

[Jennifer Bertsch [:jbertsch]]

Hi Pascal-

Could you please let us know if we need still need to do something here for L10N or if we can resolve?

Thx,
Jen

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

This bug is not fixed, we can't have a template check if a localized image exists before it falls back to English

Comment 5

[Mike Alexis [:malexis]]

Notes from requirements mtg today. Please add or edit anything missing or misconstrued:

Don’t override current media helper functionality

*create l10n directory

*specify en-US folder, not default

*output path to localized image with media URL prepending it

*will we ever need l10n specific JS file or other? Not in scope
**should be image only and we can do workaround if need any other media type

*for screenshots/banners image text needs to match alt-text

*do we want this helper to spit out path or image tag?

*needs to work for locales and locations (countries)
**will need to do something for geo as well but not in scope for teaser page.

*will file separate bug for location-based images

*discussion and decided against doing this client side

Comment 6

[Paul [:pmac] McLanahan]

There was also universal agreement that we do *not* want this to be done in a way that would allow images onto the site without a check from the team. Localized images will be checked into the bedrock repo. The localizers producing the screenshots would just need to attach them to a bug, or if they're familiar with github, submit a pull-request. One of the team would then ensure the image was sized correctly and optimized before merging it into bedrock.

Comment 7

[Paul [:pmac] McLanahan]

Attachment: Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/907

Pointer to Github pull-request

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/36f1cd0c26fcd22397800e15736ee1e5aa86a5b7
Fix bug 653876: Add l10n helper for images.

Comment 9

[Rebecca Billings [:rbillings]]

Please add QA repro steps or mark as [qa-], thanks.

Comment 10

[Paul [:pmac] McLanahan]

Marking [qa-] as there are no uses of this facility yet. It's just a tool for the devs that is now ready to use. QA will be appropriate when we actually deploy some localized images.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

pmac, we do have localized screenshots on the Firefox OS work

Comment 12

[Paul [:pmac] McLanahan]

(In reply to Pascal Chevrel:pascalc from comment #11)

Hmm... I guess that'd be up on demo2 then? I haven't seen much of that, but it would be a good spot to test it. Is there a separate bug for that work that could be more specifically tested Pascal?

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

yes, that's on demo2, localized screenshots is tracked in bug 884803