Closed Bug 653934 Opened 10 years ago Closed 10 years ago

Add a comment to point people to original Workspace repo to Scratchpad.js

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 6

People

(Reporter: rcampbell, Assigned: rcampbell)

References

()

Details

(Whiteboard: [fixed-in-devtools][merged-to-mozilla-central])

Attachments

(1 file, 1 obsolete file)

During the transition from the Workspace extension to the landed Scratchpad code, we've lost the original source history. We should add a link back to the originating repo at:

https://github.com/mozilla/workspace
Summary: Add a comment to point people to original Workspace repo to Scratchpad.xul → Add a comment to point people to original Workspace repo to Scratchpad.js
... add the link in a comment in scratchpad.js or wherever appropriate.
You can migrate a git repo to hg pretty easily; when you land this on m-c you could just hg transplant all those commits (in fact, you can even pull a git repo with hg on github) and then you lose no history.
I haven't tried it yet, but afaict using git fast-export and the hg FastImportExtension might allow one to migrate git history to hg.
Would that work for code that gets repositioned (essentially moved and/or rewritten) to fit into m-c/browser from extension space?
(In reply to comment #4)
> Would that work for code that gets repositioned (essentially moved and/or
> rewritten) to fit into m-c/browser from extension space?

My thinking was that the import would be done in a branch, we have/create a docking folder, import the extension and it's history into that folder, then write child commits which do the integration. That way the import and integration are separated.
yeah, that would work. Could even hg rename a bunch of the initial files across directories to position them and maintain history.

Hm!
Depends on: 653093
Attached patch scratchpad to workspace comment (obsolete) — Splinter Review
Pretty basic comment patch. Let me know if there's anything else this needs or if you can think of additional useful verbeage. Maybe it's sufficient!
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #529809 - Flags: review?(sdwilsh)
Attachment #529809 - Flags: feedback?
Attachment #529809 - Flags: feedback? → feedback?(erikvvold)
(In reply to comment #7)
> Created attachment 529809 [details] [diff] [review] [review]
> scratchpad to workspace comment
> 
> Pretty basic comment patch. Let me know if there's anything else this needs or
> if you can think of additional useful verbeage. Maybe it's sufficient!

Can we mention that the original project was a public domain project?
(In reply to comment #8)
> (In reply to comment #7)
> > Created attachment 529809 [details] [diff] [review] [review] [review]
> > scratchpad to workspace comment
> > 
> > Pretty basic comment patch. Let me know if there's anything else this needs or
> > if you can think of additional useful verbeage. Maybe it's sufficient!
> 
> Can we mention that the original project was a public domain project?

I'm not sure. Can we do that, Gerv?
You can say whatever you like :-) Please try not to get it tangled up with any current licensing statements, though (i.e. put it in a separate comment).

Gerv
Unfortunately, I'm traveling the so the soonest I'll be able to look at this is Monday, May 9th.
Comment on attachment 529809 [details] [diff] [review]
scratchpad to workspace comment

Maybe gavin's got a second to take a look. Also, any feedback regarding Erik's request to include some verbeage around "originally licensed as public domain" would be welcome.
Attachment #529809 - Flags: review?(gavin.sharp)
Comment on attachment 529809 [details] [diff] [review]
scratchpad to workspace comment

Comments are easy to review! You can say what you want as long as it's true!
Attachment #529809 - Flags: review?(gavin.sharp) → review+
Added the relicensing comment and a reference back to this bug.
Attachment #529809 - Attachment is obsolete: true
Attachment #529809 - Flags: review?(sdwilsh)
Attachment #529809 - Flags: feedback?(erikvvold)
Attachment #530088 - Flags: review?(gerv)
Attachment #530088 - Flags: review?(gerv) → review+
Whiteboard: [fixed-in-devtools]
Comment on attachment 530088 [details] [diff] [review]
[checked-in][in-devtools] scratchpad to workspace comment 2

http://hg.mozilla.org/projects/devtools/rev/3f6040a4e1c8
Attachment #530088 - Attachment description: scratchpad to workspace comment 2 → [in-devtools] scratchpad to workspace comment 2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-devtools] → [fixed-in-devtools][merged-to-mozilla-central]
Target Milestone: --- → Firefox 6
Comment on attachment 530088 [details] [diff] [review]
[checked-in][in-devtools] scratchpad to workspace comment 2

http://hg.mozilla.org/mozilla-central/rev/3f6040a4e1c8
Attachment #530088 - Attachment description: [in-devtools] scratchpad to workspace comment 2 → [checked-in][in-devtools] scratchpad to workspace comment 2
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.