654053 - Port bug 623950 Send startup time measurements along with metadata request

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #623950 +++

Bug 522375 plans to expose simple information about startup performance to JS. We'd like to include this in the metadata request that we send to AMO in order to be able to gather aggregated data on startup performance with certain add-ons installed. I'm not sure that this constitutes much of an additional fingerprinting risk as the number will almost certainly change for every startup but we can discuss that issue.

Comment 1

[Ludovic Hirlimann [:Usul]]

(In reply to comment #0)

> add-ons installed. I'm not sure that this constitutes much of an additional
> fingerprinting risk as the number will almost certainly change for every
> startup but we can discuss that issue.

Having numbers would et us know discover this and if we don't learn anything from these numbers, then we could remove/disable the code.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Nice simple one-line fix.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 529748 [details] [diff] [review]
The fix

Review of attachment 529748 [details] [diff] [review]:

I'm really looking forward to seeing this information, so r=me, with slight confusion as explained below.  ;)

::: mail/app/profile/all-thunderbird.js
@@ +138,4 @@
 // Preferences for AMO integration
 pref("extensions.getAddons.cache.enabled", true);
 pref("extensions.getAddons.maxResults", 15);
+pref("extensions.getAddons.get.url", "https://services.addons.mozilla.org/%LOCALE%/%APP%/api/%API_VERSION%/search/guid:%IDS%?src=thunderbird&appOS=%OS%&appVersion=%VERSION%&tMain=%TIME_MAIN%&tFirstPaint=%TIME_FIRST_PAINT%&tSessionRestored=%TIME_SESSION_RESTORED%");

That seems like an odd place to add the metadata, but if you think that's where it should go, I'll trust you…

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> That seems like an odd place to add the metadata, but if you think that's where
> it should go, I'll trust you…

Yep maybe, but its exactly the same as attachment 505523 [details] [diff] [review].

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/82c95f65d579