Closed Bug 654131 Opened 9 years ago Closed 9 years ago

Firefox 4 update/installer failed to scrub old java extensions

Categories

(Firefox :: Installer, defect)

4.0 Branch
x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 8
Tracking Status
firefox6 - ---

People

(Reporter: timeless, Assigned: robert.strong.bugs)

References

Details

Attachments

(4 files)

bug 597235 was supposed to deal with this....

I'm visiting a work computer, it has the following in
C:\Program Files\Mozilla Firefox\extensions:
{CAFEEFAC-0016-0000-0017-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0020-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0023-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0024-ABCDEFFEDCBA}
(as well as .net framework and skype extensions...)

these are apparently u17, u20, u23, and u24. only u24 should be present - it isn't current, but it's the latest one installed on this system.

  Application Basics
        Name
        Firefox

        Version
        4.0

        User Agent
        Mozilla/5.0 (Windows NT 6.0; rv:2.0) Gecko/20100101 Firefox/4.0

  Extensions

        Name

        Version

        Enabled

        ID

        Microsoft .NET Framework Assistant
        1.2.1
        false
        {20a82645-c095-46ed-80e3-08825760534b}

        Skype extension
        5.0.0.6906
        false
        {AB2CE124-6272-4b12-94A9-7303C7397BD1}

        Java Console
        6.0.17
        true
        {CAFEEFAC-0016-0000-0017-ABCDEFFEDCBA}

        Java Console
        6.0.20
        true
        {CAFEEFAC-0016-0000-0020-ABCDEFFEDCBA}

        Java Console
        6.0.23
        true
        {CAFEEFAC-0016-0000-0023-ABCDEFFEDCBA}

        Java Console
        6.0.24
        true
        {CAFEEFAC-0016-0000-0024-ABCDEFFEDCBA}

I was asked to file this bug by someone in mozilla.public.dev-planning. I will not have access to this computer in the future.

If there's a mozilla installer/updater log file that should be collected, please indicate it ASAP or else it is unlikely that anyone will be able to retrieve it. I believe this was an update via the menu from firefox3.6.x.

for internal reference, this is the team Skype computer.
Thanks timeless, could you check if there is an uninstall.log file in the uninstall directory?
Attached file 4.0 log
To check the post update cleanup of the files run cmd.exe as admin, cd into <firefox install dir>\uninstall\, and run helper.exe /PostUpdate.
I did that, nothing happened / no files were deleted....
Thanks, it appears that dir paths can no longer end with a \... pretty sure it worked back when we used NSIS 2.22. Before I submit a patch I'm going to audit usage.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Bug 659772 also says the console can also exist with ID {CAFEEFAC-0016-0000-0026-ABCDEFFEDCBA}.
I can confirm that there are more than 76 million installations of Java Console in Firefox 4 and later. This bug is fairly important, as these add-ons are likely not compatible and users may be reluctant to upgrade thinking they are losing functionality.

If you need an updated list of GUIDs, let me know.
(In reply to comment #8)
> I can confirm that there are more than 76 million installations of Java
> Console in Firefox 4 and later. This bug is fairly important, as these
> add-ons are likely not compatible and users may be reluctant to upgrade
> thinking they are losing functionality.

-> requesting tracking-firefox6 (our next update)
These are all of the active Java Console GUIDs.
Attached patch patchSplinter Review
Jim, turns out that the check if a dir exists will fail if the path ends in a slash. :( Reminds me of how stat will return ENOENT when checking a dir path that ends with a slash. This also adds a couple of new java console extensions to the list that have a large number of users.
Attachment #550544 - Flags: review?(jmathies)
Comment on attachment 550544 [details] [diff] [review]
patch

I hate these things, they are so annoying!
Attachment #550544 - Flags: review?(jmathies) → review+
Whiteboard: [fx-team] → [fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/ec8abe32a3a5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Unmarking tracking for 8 since this made the uplift.
You need to log in before you can comment on or make changes to this bug.