Closed Bug 597235 Opened 9 years ago Closed 9 years ago

Remove Java Console extensions in the install directory's extensions directory on install and app update

Categories

(Firefox :: Installer, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: rstrong, Assigned: rstrong)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Years ago the Sun JRE installed a new version with a different ID of their Java Console extension for every new version of the JRE. We discussed this with them and they stopped shipping the Java Console extension with the JRE but there are a lot of users out their that have multiple Java Console extensions all with a unique ID for the version and we should remove these on install and app update.

Kev is looking for a JRE contact at Oracle since our previous contacts at Sun are no longer applicable to let them know about this decision.

This will likely make bug 596392 negligible to the point where it really doesn't need to be fixed and it will provide a much better user experience by removing the on upgrade compatibility check for these add-ons.
Before I forget, people did all the work on this as well with bug 533559, already, I think. Adding Tony and Jorge for comment, as well.
Attached patch pach rev1Splinter Review
Removes the four versions noted in bug 533559.
{CAFEEFAC-0015-0000-0012-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0000-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0001-ABCDEFFEDCBA}
{CAFEEFAC-0016-0000-0002-ABCDEFFEDCBA}

Since the user won't always have the rights required to uninstall the extension this approach will be more successful at removing them since the installer and updater will always have rights to remove them.
Attachment #477255 - Flags: review?(jmathies)
The add-ons that are currently listed on addons.mozilla.org have code to uninstall themselves. The only reason people should still have any version of this add-on is that they refuse or neglect to upgrade.
Though it  has been a couple of years since I was the owner of the EM I am quite certain we don't offer updates for an add-on that is installed to a location that the user doesn't have write access to with Firefox 3.6 and below.

To verify, on Win Vista or Win 7 install an extension into the installation directory's extensions directory (this is iirc what the Java Console was doing though I might be wrong since it has been more than a couple of years since I had bi-weekly meetings with them on this issue). The installation directory must be under program files and UAC must be turned on. Then try it out.

You can also verify this by installing under program files as admin on Win2K and WinXP and logging on as a non-admin user.

On trunk, we only update compatibility information for add-ons installed into the installation directory's extensions directory.
This should probably block final
blocking2.0: --- → ?
blocking2.0: ? → final+
Attachment #477255 - Flags: review?(jmathies) → review+
(In reply to comment #3)
> The add-ons that are currently listed on addons.mozilla.org have code to
> uninstall themselves. The only reason people should still have any version of
> this add-on is that they refuse or neglect to upgrade.

Actually, Sun's primary distribution mechanism for the java console is a direct install to the app directory via the Java Updater.  As a result, these add-ons cannot be removed nor updated, only disabled.  I agree with the plan to remove these extensions.
There are 33 versions of the Java Console extension
Attachment #495900 - Flags: review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/de295f93a28a
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.