654133 - Unable to reuse IDs for deleted self hosted addons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect, P3)

Description

[Mike Kaply [:mkaply]]

My understanding was that as part of this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=636834

all remnants of our self hosted addons were going to be removed from the system.

We recently decided to make a few of our old self hosted addons AMO hosted, but we are getting a "duplicate ID" error.

So these things still exist in the system somewhere.

the ones we ran into were 

[e-mail] and [e-mail]

Not sure what the right thing to do is here.

Comment 1

[Justin Scott [:fligtar]]

Are there any GUIDs besides those 2 you need removed from the submission blacklist?

Comment 2

[Mike Kaply [:mkaply]]

Yes. It will happen over time as we see which have enough users to want us to put them on AMO as well.

[e-mail] comes to mind.

What is this submission blacklist?

I didn't realize this would be a consequence of removing the self hosted stuff from our list.

Comment 3

[Justin Scott [:fligtar]]

Any time an add-on is deleted from AMO we add its guid to a blacklist. This is because most add-ons have active users that will continue to ping AMO, and someone else could submit that add-on's GUID and steal those users.

If you'd like me to remove all @brandthunder.com entries I can do that, or I can just remove these 3. But I don't want to remove them one at a time every few weeks, so please let me know which you'd prefer.

Comment 4

[Mike Kaply [:mkaply]]

I guess a better question then is why self hosted addons relied on GUIDs at all, since the XPI wasn't hosted on AMO and no statistics were gathered.

Separate issue though.

Not all the IDs will end in @brandthunder.com, so it's not easy to find them all. But yes, the easiest place to start would be to remove the ones I referenced and all @brandthunder.com entries.

thanks

Comment 5

[Justin Scott [:fligtar]]

Removed these GUIDs:

    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]
    Blacklisted guid: [e-mail]

Comment 6

[Mike Kaply [:mkaply]]

Will this take some time to mirror? We're still unable to submit the addons.

Comment 7

[Mike Kaply [:mkaply]]

We're still unable to submit using any of these IDs

Comment 8

[Justin Scott [:fligtar]]

Huh, it seems the self-hosted add-ons were only disabled so they're still in the add-ons table, yet they were also somehow added to the blacklisted guids table as though they were deleted.

This will need a dev to figure out what's going on.

Comment 9

[Mike Kaply [:mkaply]]

This is starting to seriously impact us. Who is a dev that could investigate?

Comment 10

[Wil Clouser [:clouserw]]

Dave wrote the script in bug 636834 - Dave, can you shed any light on this?

Comment 11

[Mike Kaply [:mkaply]]

This is impacting our business. Can someone please take a look?

Comment 12

[Wil Clouser [:clouserw]]

Dave is out this week.  Andy, could you see what happened when that script ran?

Comment 13

[Andy McKay]

I was not able to reproduce getting the addons into this state and there isn't anything in the logs. In preview we've got some blacklisted guids and some of the addons. 

So I've gone for the brute force approach and created a script that deletes all guids mentioned above. Then delete's all the addons, then delete's all the guids again. When run we should end up with a db with none of the listed guids or addons in them.

https://github.com/jbalogh/zamboni/commit/34b7fa233e673c71b8d445872d970ebfeeeb85a4

Comment 14

[Mike Kaply [:mkaply]]

How soon will this happen?

We're still unable to use these IDs.

Comment 15

[Wil Clouser [:clouserw]]

It'll go out next Thursday