Closed Bug 654170 Opened 12 years ago Closed 11 years ago

Make js_InitArrayClass non-generic


(Core :: JavaScript Engine, defect)

Not set





(Reporter: Waldo, Assigned: Waldo)


(Whiteboard: [inbound])


(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Another step toward making bootstrapping special.  This also happens to fix the long-standing bug 592296.  \o/

I'm continuing to stick with jorendorff because he's reviewed the other de-generifying patches.  Note that Array has some special-case handling in js_InitClass which makes this slightly more complicated than RegExp and String were, although not too horribly tricky.

In theory I could remove the Array-specific complexity from js_InitClass now, but it seems better to leave that for a final cleanup once all standard-class initialization is made special.
Attachment #529516 - Flags: review?(jorendorff)
Comment on attachment 529516 [details] [diff] [review]

Clearing the review bit since I r-'d all the patches along these lines, and Jeff has a new approach that I'm going to be reviewing today.
Attachment #529516 - Flags: review?(jorendorff)
Attached patch Updated patchSplinter Review
This builds on a bunch of the minor abstractions you've already reviewed, or will be reviewing.  It also consolidates some of the old code a bit, now that Array's special-casing has been removed from the general code path.  The comments indicate why more special-casing can't yet be removed, and what needs to be done to do so.
Attachment #529516 - Attachment is obsolete: true
Attachment #545547 - Flags: review?(bhackett1024)
Comment on attachment 545547 [details] [diff] [review]
Updated patch

Review of attachment 545547 [details] [diff] [review]:
Attachment #545547 - Flags: review?(bhackett1024) → review+
This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange.
Whiteboard: [inbound]
Target Milestone: mozilla6 → mozilla8
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.