|
4.86 KB,
patch
|
bhackett
:
review+
|
Details | Diff | Splinter Review |
Created attachment 529516 [details] [diff] [review] Patch Another step toward making bootstrapping special. This also happens to fix the long-standing bug 592296. \o/ I'm continuing to stick with jorendorff because he's reviewed the other de-generifying patches. Note that Array has some special-case handling in js_InitClass which makes this slightly more complicated than RegExp and String were, although not too horribly tricky. In theory I could remove the Array-specific complexity from js_InitClass now, but it seems better to leave that for a final cleanup once all standard-class initialization is made special.
|
||
Comment 1•6 years ago
|
||
Comment on attachment 529516 [details] [diff] [review] Patch Clearing the review bit since I r-'d all the patches along these lines, and Jeff has a new approach that I'm going to be reviewing today.
|
(Assignee) | |
Comment 2•6 years ago
|
||
Created attachment 545547 [details] [diff] [review] Updated patch This builds on a bunch of the minor abstractions you've already reviewed, or will be reviewing. It also consolidates some of the old code a bit, now that Array's special-casing has been removed from the general code path. The comments indicate why more special-casing can't yet be removed, and what needs to be done to do so.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 545547 [details] [diff] [review] Updated patch Review of attachment 545547 [details] [diff] [review]: -----------------------------------------------------------------
|
||
Comment 4•6 years ago
|
||
This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange.
|
|
(Assignee) | |
Comment 5•6 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/ada72f2e38df
|
||
Comment 6•6 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ada72f2e38df
Description
•