Closed Bug 654402 Opened 9 years ago Closed 9 years ago
"Copies & Folders" page in Account Settings is cut off
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 Build Identifier: This was reported in bug 607295, the changes introducing a separate "Message Archives" section resulted in the layout being cut off at the bottom - at least on Windows 7. Fortunately the window is resizable, but the default dialog size (or persisted old values) seems to be too small now. See attachment 528421 [details] for a screenshot. Reproducible: Always
Confirming this bug on Windows 7. Increasing the height value in <!ENTITY accountManager.size "width: 121ch; height: 49em;"> seems to have no effect?
Height should be set to 53em for Win 7.
Alex, can you come up with a patch ?
Component: General → Account Manager
QA Contact: general → account-manager
Note, XUL cache must be cleared to see the correct new (default) dialog size. Not sure about the necessary window size for Unix / OS X.
Comment on attachment 533299 [details] [diff] [review] comm-central patch Well, the problem still exists on Mac, which seems to need at least 55em, and the uploaded patch doesn't seem to be valid, because hg doesn't handle UTF-16 well, but applying the change manually works for me. So that leaves me in a really weird spot. I think I've got to go with ui-r+, but r-. But I think this patch is really close to working, and the next version will probably just get an r+ from me. (You can carry forward the ui-r+ from this patch.) Thanks, Blake.
Sorry, maybe someone else could finish this 1-line patch.
Assignee: AlexIhrig → nobody
Yeah, I'll take this.
Changing to 55em as requested.
Comment on attachment 536276 [details] [diff] [review] patch v2 Review of attachment 536276 [details] [diff] [review]: ----------------------------------------------------------------- Looks great! r=me, with my thanks.
Attachment #536276 - Flags: review?(bwinton) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Checked into comm-miramar: http://hg.mozilla.org/releases/comm-miramar/rev/465ab9fa5ba0
Attachment #536276 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/565662e5adb8
You need to log in before you can comment on or make changes to this bug.