654426 - Bad display of compose window addressing indicators on Mac following bug 642163

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Mark Banner (:standard8)]

Attachment: Screenshot

See the attached screenshot.

There's two issues here:

1) For some reason the second and third lines have buttons that seem to be slightly taller.
2) The Newsgroup: text is partially obscured (same with Follow-up to: but that isn't shown here).

I'm not sure what is best for the newsgroup text here. Maybe smaller text or a tooltip. Although I'm not convinced a tooltip is really that good for something we should be able to display on the default UI.

Comment 1

[Richard Marti (:Paenglab)]

I had only one time access to a Mac for the checks. Actually I have no Mac and I can't investigate this strange problem.

About the obscured text: the screenshot shows on the left of Newsgr... more space than the menulist on top (the one after From: ). Maybe it's possible to work with padding/margin. If nothing helps, maybe a new entity in messengercompose.dtd especially for Mac bigger width than for the others can do it.

Comment 2

[Mark Banner (:standard8)]

I'm not sure I'd want to go for a bigger width - it already feels like there's a whole load of empty space outside those areas.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Addressing only the truncated aw-menulist

Standard8 please can you try this patch? I had today the same problem under WinXP by changing aw-menulist to a more native menulist.

Important: this patch don't solve the different height.

Comment 5

[rsx11m]

Richard, I'm going to reopen 654916 as I can reproduce this on other platforms as well, thus it's independent from the Mac-specific menu-width issue here.

Comment 6

[Richard Marti (:Paenglab)]

Attachment 530862 [details] in Bug 654916 shows the result with both patches applied. The unequal height looks solved, but the truncation not. The menulists are also to high aligned.

Attachment 530865 [details] shows also some problems with the focus ring.

:andreasn, is it okay to address the truncation and the focus ring problems in this Bug, because this is Mac only? I think, the focus ring issue is correlated to the aligning.

Comment 7

[Andreas Nilsson (:andreasn)]

Richard: Yeah, I think that makes sense to solve that in this bug

Comment 8

[Andreas Nilsson (:andreasn)]

.aw-menulist > .menulist-label {
  font: icon;
  -moz-margin-end: 3px;
  font-size: 10px;
}

Seems like the above does the trick (for newsgroup at least, not for Followup-to yet). I think my qseries is broken, but I'll try and make a patch.

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: patch fixing trunkation

Comment 10

[Richard Marti (:Paenglab)]

Andreas: The dropmarker is now on the right side. Before the composer patches it was on the left.

For winXP I used this:

/* set the dropmarker at the beginning of the aw-menulist */
.aw-menulist:-moz-locale-dir(ltr),
.aw-menulist > .menulist-label-box:-moz-locale-dir(rtl) {
  direction: rtl; 
}

.aw-menulist:-moz-locale-dir(rtl),
.aw-menulist > .menulist-label-box:-moz-locale-dir(ltr) {
  direction: ltr; 
}

Maybe this works also for OSX

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: This should do the trick

* Sets font size to 10px (same as the other widgets)
* Adds Richards padding from attachment 530127 [details] [diff] [review]
* Adds the rtl thing, so all labels become right aligned.

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of above patch in action

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 531314 [details] [diff] [review]
This should do the trick

That looks very nice to me!

Thanks,
Blake.

Comment 14

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/22fe617c4cbd