654594 - Remove WinCE & Windows Mobile code from security/coreconf/

Status: RESOLVED DUPLICATE of bug 654611

(NSS :: Libraries, defect, P3)

Description

[Ed Morley [:emorley]]

WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the security/coreconf/* parts of the removal:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/security/coreconf/

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from security/coreconf/*

Remove WinCE ifdefs from security/coreconf/ and also hg rm:
security/coreconf/WINCE.mk

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 529868 [details] [diff] [review]
Remove WinCE code from security/coreconf/*

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=357126c2abd1

Comment 3

[Kai Engert [:KaiE:]]

directory security/coreconf belongs to NSS, changing component

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 529868 [details] [diff] [review]
Remove WinCE code from security/coreconf/*

r=kaie

Comment 5

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from security/coreconf/*

Only change is updated commit message to include r=kaie
Carrying forwards r+

-

Kai - thanks for the review / moving to the correct component :-)

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

This is a Hg patch, a patch to Firefox's downstream copy of NSS. 
Has a maintainer of that copy been identified?

Comment 7

[Ed Morley [:emorley]]

The patch is intended for NSS CVS upstream, sorry for any confusion.

It's only hg since http://www.mozilla.org/projects/security/pki/nss/ appeared out of date - so I thought the mention of CVS was an oversight (like on many of the MDN pages); so (incorrectly) presumed that development had moved to the mercurial m-c repo along with everything else. The NSS entry here https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure also also didn't mention development having to occur on another repo.

If upstream wishes to wontfix, then it's not worth taking for m-c only.

Comment 8

[Kai Engert [:KaiE:]]

(In reply to comment #6)
> This is a Hg patch, a patch to Firefox's downstream copy of NSS. 
> Has a maintainer of that copy been identified?

Nelson, no reason to worry.
Patches can be created using hg, and still applied to a cvs tree.

The copy in mozilla-central is a... copy. No need for a maintainer.

Comment 9

[Kai Engert [:KaiE:]]

(In reply to comment #7)
> 
> If upstream wishes to wontfix, then it's not worth taking for m-c only.

I guess we want to take it, if wince is dead.
I will raise the question during the NSS conference call, prior to checking in.

Comment 10

[Ed Morley [:emorley]]

(In reply to comment #9)
> I will raise the question during the NSS conference call, prior to checking in.

Thanks Kai :-)

Comment 11

[Kai Engert [:KaiE:]]

The following has been discussed in today's NSS conference call:

- in theory, there might be additional users of this code
- we don't want to remove it if there is still someone using it
- in order to find out, a message will be sent to the dev-crypto newsgroup

- if someone actively uses it, we'll keep it
- if not, we'll remove it at some later time.

Which means, despite having a r+ patch,
please don't check in yet.

Comment 12

[Ed Morley [:emorley]]

> - in theory, there might be additional users of this code
> - we don't want to remove it if there is still someone using it
> - in order to find out, a message will be sent to the dev-crypto newsgroup

For reference: 
https://groups.google.com/d/topic/mozilla.dev.tech.crypto/Fb7BrL5m9y0/discussion

Comment 13

[Ed Morley [:emorley]]

Contents of patch moved to the main NSS bug 654611 to keep everything together.