Last Comment Bug 654600 - Remove WinCE code from security/manager/Makefile.in
: Remove WinCE code from security/manager/Makefile.in
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: PSM (show other bugs)
: Trunk
: All Windows CE
: -- normal (vote)
: mozilla6
Assigned To: Ed Morley [:emorley]
:
:
Mentors:
Depends on:
Blocks: 614720
  Show dependency treegraph
 
Reported: 2011-05-03 16:12 PDT by Ed Morley [:emorley]
Modified: 2011-05-06 09:03 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove WinCE code from security/manager/Makefile.in (2.60 KB, patch)
2011-05-03 16:14 PDT, Ed Morley [:emorley]
kaie: review+
Details | Diff | Splinter Review
Remove WinCE code from security/manager/Makefile.in (2.61 KB, patch)
2011-05-04 12:12 PDT, Ed Morley [:emorley]
emorley: review+
Details | Diff | Splinter Review

Description Ed Morley [:emorley] 2011-05-03 16:12:18 PDT
WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the security/manager/* parts of the removal:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/security/manager/
Comment 1 Ed Morley [:emorley] 2011-05-03 16:14:47 PDT
Created attachment 529873 [details] [diff] [review]
Remove WinCE code from security/manager/Makefile.in
Comment 2 Ed Morley [:emorley] 2011-05-04 05:28:24 PDT
Comment on attachment 529873 [details] [diff] [review]
Remove WinCE code from security/manager/Makefile.in

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=357126c2abd1
Comment 3 Kai Engert (:kaie) 2011-05-04 11:49:07 PDT
Comment on attachment 529873 [details] [diff] [review]
Remove WinCE code from security/manager/Makefile.in

r=kaie
Comment 4 Ed Morley [:emorley] 2011-05-04 12:12:39 PDT
Created attachment 530113 [details] [diff] [review]
Remove WinCE code from security/manager/Makefile.in

Only change is updated commit message to include r=kaie

Carrying forwards r+
Comment 5 Ed Morley [:emorley] 2011-05-05 09:55:36 PDT
http://hg.mozilla.org/mozilla-central/rev/16772cb4a781

Thanks Matt :-)
Comment 6 Matt Brubeck (:mbrubeck) 2011-05-05 14:35:05 PDT
Backed out because something that landed with this caused a new orange (Win debug Moth tabview/browser_tabview_bug597248.js):
http://hg.mozilla.org/mozilla-central/rev/eaaa24ff93a0

This can probably land again once we figure out the cause of the test failures.
Comment 7 Matt Brubeck (:mbrubeck) 2011-05-06 09:03:11 PDT
re-landed:
http://hg.mozilla.org/mozilla-central/rev/50c8d7195602

Note You need to log in before you can comment on or make changes to this bug.