Closed Bug 654687 Opened 13 years ago Closed 12 years ago

Combine stop and reload in the page context menu as done with the toolbar buttons by default

Categories

(Firefox :: Menus, enhancement)

Product:
Firefox
Component:
Menus
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: tech4pwd, Assigned: jaws)

References

Details

(Keywords: ux-consistency, ux-minimalism)

Attachments

(1 file)

Patch
6.44 KB, patch
Felipe
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110503 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110503 Firefox/6.0a1

By default the Stop and Reload buttons have been combined in the navigation bar. The in page context menu should match this design decision.

Reproducible: Always
Version: unspecified → Trunk
Rather an RFE Report.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: uiwanted
Keywords: ux-consistency, ux-minimalism
There's no "stop" context menu item; adding one certainly doesn't qualify as simplification...
Keywords: ux-minimalism
Whiteboard: wontfix?
When I right click on a page, I see 'Back, Forward, Reload, Stop'.
Oh, this is about the page context menu. I assumed this was about the tab context menu.
Summary: Combine stop and reload in the context menu as done with the toolbar buttons by default → Combine stop and reload in the page context menu as done with the toolbar buttons by default
Apologies, I should've been more specific in the summary. Thanks for fixing it.
See Also: → 343396
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Keywords: uiwanted → ux-minimalism
Whiteboard: wontfix?
Attached patch Patch — — Splinter Review 
This patch makes it so that context-reload and context-stop are mutually exclusive. It checks if the stopCommand is disabled to know if the page is still loading.

Tested changes with test_contextmenu.html locally.
Attachment #638946 - Flags: review?(felipc)
Attachment #638946 - Flags: review?(felipc) → review+
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2237382fc721
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/2237382fc721
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 780083
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: