Combine stop and reload in the page context menu as done with the toolbar buttons by default

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Menus
--
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Paul [pwd], Assigned: jaws)

Tracking

({ux-consistency, ux-minimalism})

Trunk
Firefox 16
ux-consistency, ux-minimalism
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110503 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110503 Firefox/6.0a1

By default the Stop and Reload buttons have been combined in the navigation bar. The in page context menu should match this design decision.

Reproducible: Always
(Reporter)

Updated

6 years ago
Version: unspecified → Trunk
Rather an RFE Report.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: uiwanted
(Reporter)

Updated

6 years ago
Keywords: ux-consistency, ux-minimalism
There's no "stop" context menu item; adding one certainly doesn't qualify as simplification...
Keywords: ux-minimalism
Whiteboard: wontfix?
(Reporter)

Comment 3

6 years ago
When I right click on a page, I see 'Back, Forward, Reload, Stop'.
Oh, this is about the page context menu. I assumed this was about the tab context menu.
Summary: Combine stop and reload in the context menu as done with the toolbar buttons by default → Combine stop and reload in the page context menu as done with the toolbar buttons by default
(Reporter)

Comment 5

6 years ago
Apologies, I should've been more specific in the summary. Thanks for fixing it.
(Reporter)

Updated

6 years ago
See Also: → bug 343396
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Keywords: uiwanted → ux-minimalism
Whiteboard: wontfix?
Created attachment 638946 [details] [diff] [review]
Patch

This patch makes it so that context-reload and context-stop are mutually exclusive. It checks if the stopCommand is disabled to know if the page is still loading.

Tested changes with test_contextmenu.html locally.
Attachment #638946 - Flags: review?(felipc)
Attachment #638946 - Flags: review?(felipc) → review+
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2237382fc721
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/2237382fc721
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 780083
You need to log in before you can comment on or make changes to this bug.