780083 - stop/reload does not work properly in a web-panels.xul

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[fx4waldi]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120802040204

Steps to reproduce:

1. Open the page in the sidebar
2. Right click - context menu will appear
3. Click on Stop
4. Stop should be changed to Reload
5. Always is only stop and you can not refresh the page

Comment 1

[Dão Gottwald [:dao]]

Jared, sounds like your patch broke this. Can you look into it?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, I'll look in to this. Thanks for pinging me.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: WIP Patch

This is a WIP patch of what I have so far for this bug. I need to get the test working correctly.

The solution that I used within nsContextMenu.js in this patch isn't going to be good enough because document.readyState doesn't become loading until the response starts.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

I used mozregression and I couldn't get the Stop/Reload context menu items on the sidebar browser to work in any version leading all the way back to 2008-09-04 and stopped there.

The effort to get these working is probably not worth it, it may just be better to hide these context menus for sidebars.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Unassigning as I haven't been working on this and I don't want to hold people up.

Comment 6

[Martin Giger [:freaktechnik]]

I wonder if this got fixed with bug 1299371, since that hides these elements whenever not in a tabbed browser environment.

Comment 7

[Martin Giger [:freaktechnik]]

This is indeed fixed for me on Nightly 20170514030207 64-bit on Win 10.