Remove WinCE code from xpfe/*

RESOLVED FIXED in mozilla6

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla6
All
Windows CE
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the xpfe/* parts of the removal:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpfe/
(Assignee)

Comment 1

6 years ago
Created attachment 530062 [details] [diff] [review]
Remove WinCE code from xpfe/*
Assignee: nobody → bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Comment on attachment 530062 [details] [diff] [review]
Remove WinCE code from xpfe/*

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=ed18eff9dd9a

Thanks!
Attachment #530062 - Flags: review?(neil)

Comment 3

6 years ago
Comment on attachment 530062 [details] [diff] [review]
Remove WinCE code from xpfe/*

This block is all obsolete with libxul anyway isn't it? IIRC it only existed because MSVC wouldn't inline nsIntRect so shared builds wouldn't link.
Attachment #530062 - Flags: review?(neil) → review?(khuey)
Yeah, this is all obsolete anyways.  Lets just let the "cleanup libxul stuff" bug get this.
Attachment #530062 - Flags: review?(khuey)
(Assignee)

Comment 5

6 years ago
Do you mean bug 648911?

If so, it doesn't touch this file. Should it?
Maybe.  I'd r+ a patch that just removes the whole ifeq block.
(Assignee)

Comment 7

6 years ago
What does/did gkgfx do?

MXR doesn't return much for it and the gkgfx seems to no longer exist?
gkgfx was the shared library that gfx/ ended up in.
(Assignee)

Comment 9

6 years ago
Created attachment 531660 [details] [diff] [review]
Remove WinCE code from xpfe

Removes the whole ifeq block, per comment 6 suggestion. Isn't removed in the current bug 648911 patch, so doing here instead.

Couldn't tell from comment 6 if the r+ was implicit or whether I needed to re-request, so though I should r? just in case.

Thanks!
Attachment #530062 - Attachment is obsolete: true
Attachment #531660 - Flags: review?(khuey)
Comment on attachment 531660 [details] [diff] [review]
Remove WinCE code from xpfe

It was implicit, but I'll put the stamps here anyways.
Attachment #531660 - Flags: review?(khuey) → review+
(Assignee)

Comment 11

6 years ago
Thanks :-)
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/13ad023ee970
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Pushed:
http://hg.mozilla.org/mozilla-central/rev/13ad023ee970
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.