654723 - Remove WinCE code from dbm/*

Status: RESOLVED DUPLICATE of bug 654611

(NSS :: Libraries, defect, P3)

Description

[Ed Morley [:emorley]]

WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the dbm/* parts of the removal:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/dbm/

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from dbm/* (incl DBM_REOPEN_ON_FLUSH)

Also removes DBM_REOPEN_ON_FLUSH code, now that it is no longer defined:
http://mxr.mozilla.org/mozilla-central/search?string=DBM_REOPEN_ON_FLUSH

Comment 2

[Ed Morley [:emorley]]

It would appear that this belongs in the NSS product, my bad.

For clarity, this bug is for consideration for upstream NSS. If NSS would rather wontfix, then that's fine, no m-c specific changes will be made (it's just not worth it).

Comment 3

[Ed Morley [:emorley]]

Passed try:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=ed18eff9dd9a

However will wait to see if NSS will accept this patch (and the other WinCE removal bugs) before hassling someone with a review request. (And will obviously need to convert to a patch against the CVS repo as well).

Comment 4

[Ed Morley [:emorley]]

From bug 654611 comment #8...

> The following has been discussed in today's NSS conference call:
> 
> - in theory, there might be additional users of this code
> - we don't want to remove it if there is still someone using it
> - in order to find out, a message will be sent to the dev-crypto newsgroup
> 
> - if someone actively uses it, we'll keep it
> - if not, we'll remove it at some later time.

The newsgroup posting: 
https://groups.google.com/d/topic/mozilla.dev.tech.crypto/Fb7BrL5m9y0/discussion

Comment 5

[Ed Morley [:emorley]]

Contents of patch moved to the main NSS bug 654611 to keep everything together.