Closed
Bug 654756
Opened 14 years ago
Closed 14 years ago
update tegra cleanup.py step and sut_lib to check for xpcshell pidfile
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bear, Assigned: bear)
References
Details
Attachments
(1 file)
|
3.56 KB,
patch
|
mozilla
:
review+
bear
:
checked-in+
|
Details | Diff | Splinter Review |
Bug 654116 creates a pidfile for the xpcshell process so now we can add it to the list of processes to check during the Tegra cleanup.py step
|
Assignee | |
Updated•14 years ago
|
Attachment #530076 -
Attachment is patch: true
Attachment #530076 -
Attachment mime type: text/x-patch → text/plain
Attachment #530076 -
Flags: review?(aki)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 530076 [details] [diff] [review]
check for xpcshell pidfile during cleanup step
> if not killPID(pid, includeChildren=True):
>- log.debug('second attempt to kill %s' % pid)
>+ log.debug('second attempt to kill %s' % (label, pid))
You appear to be missing the first %s: here.
r=me with that fixed.
Attachment #530076 -
Flags: review?(aki) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 530076 [details] [diff] [review]
check for xpcshell pidfile during cleanup step
committed changeset 1397:0345938ef487
Attachment #530076 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•