654961 - [10.4] Location bar is buggy with HTTPS

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Pierre Rudloff]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.2.18pre) Gecko/20110504 Camino/2.1a2pre (like Firefox/3.6.18pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.2.18pre) Gecko/20110504 Camino/2.1a2pre (like Firefox/3.6.18pre)

There is a strange gradient in the location bar on HTTPS pages.

Reproducible: Always

Comment 1

[Pierre Rudloff]

Attachment: Screenshot

Comment 2

[Samuel Sidler (:ss)]

I wonder if this is a 10.4 bug with the new icon holder (I still can't remember what we're calling that).

Comment 3

[Chris Lawson (gone)]

Might be; I definitely do *not* see this on 10.6.

Comment 4

[Pierre Rudloff]

Yes, I did not have it on 10.6 the other day.

Comment 5

[Chris Lawson (gone)]

Hrm. Do we care enough to investigate and fix this? It *is* obviously a bug, and probably 10.4-only, but how many people is that really affecting at this point?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If it really is broken on 10.4, we ought to look into it; it's pretty ugly, and we're likely to really start hearing about it once people upgrade to 2.1.  The problem is going to be finding a 10.4 box to look into it on… :(

Comment 7

[Stuart Morgan]

Looks like drawing "clear" isn't doing what we want on 10.4. I vote we just make drawing the gradient conditional on 10.5+; 10.4 users won't get the fancy text fade, but won't get the ugly behavior in the screenshot.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Stuart Morgan from comment #7)
> make drawing the gradient conditional on 10.5+; 10.4 users won't get the
> fancy text fade, but won't get the ugly behavior in the screenshot.

The grey partition gradient, or the "fade" gradient?  I'd rather just drop the latter, if possible (but if not, yeah, drop both).

Stuart, can you take this one?  I'd rather not learn gradients at this point in time ;)

(I did confirm on cb-x1 that we see what Pierre's screenshot shows.)

Comment 9

[Stuart Morgan]

Just the fade. I'll try to get to this soon.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If we have to respin for bug 702067, do you think you might be able to get this ready to ride along?

Comment 11

[Stuart Morgan]

Attachment: fix

Yep

Comment 12

[Stuart Morgan]

Whoops, ignore the random OS symbol seed change in that patch; I thought my tree was clean.

Comment 13

[Stuart Morgan]

http://hg.mozilla.org/camino/rev/731672f52bbb

Leaving the 2.1/2.1.1 flags alone since the respin isn't decided yet.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/ceab63b5a40a for CAMINO_2_1_MINIBRANCH

Our 10.4 users thank you ;)